On Thu, Oct 28, 2010 at 10:54 AM, Sergei Shtylyov sshtylyov@mvista.com wrote:

Hello.

On 28-10-2010 18:04, Nori, Sekhar wrote:

...

Sorry for jumping late on this. Some comments below:

...

...

From: Victor Rodriguezvictor.rodriguez@sasken.com

...

...

This patch adds EMAC support for the Hawkboard-L138 system

...

...

Signed-off-by: Victor Rodriguezvictor.rodriguez@sasken.com

arch/arm/mach-davinci/board-omapl138-hawk.c |   47 +++++++++++++++++++++++++++  1 files changed, 47 insertions(+), 0 deletions(-)

...

...

diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c index c472dd8..8633245 100644 --- a/arch/arm/mach-davinci/board-omapl138-hawk.c +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c @@ -19,6 +19,51 @@

#include<mach/cp_intc.h>  #include<mach/da8xx.h> +#include<mach/mux.h>

+#define HAWKBOARD_PHY_ID             "0:07"

+static short omapl138_hawk_mii_pins[] __initdata = {

• DA850_MII_TXEN, DA850_MII_TXCLK, DA850_MII_COL, DA850_MII_TXD_3,
• DA850_MII_TXD_2, DA850_MII_TXD_1, DA850_MII_TXD_0, DA850_MII_RXER,
• DA850_MII_CRS, DA850_MII_RXCLK, DA850_MII_RXDV, DA850_MII_RXD_3,
• DA850_MII_RXD_2, DA850_MII_RXD_1, DA850_MII_RXD_0, DA850_MDIO_CLK,
• DA850_MDIO_D,
• -1

...

-1 need not be a new line. In any case, please include a ',' after it.

Why is that? It's always a last entry in the array.

WBR, Sergei

Hey Sergei these patches have been tested by Rene Gonzales and ack by Liam and Mark Brown , I am going to send the patches V6 because of this change. I have been rechecking the code and seems that there is no problem on it, do you have any other comment before i send the series of patches v6 ?

Thanks a lot for your comments

Really appreciated

Victor Rodriguez