[alsa-devel] [PATCH] ALSA: hda: hdmi - add Tigerlake support
Add Tigerlake HDMI codec support.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205379 BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=112171 Cc: Pan Xiuli xiuli.pan@linux.intel.com Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com --- sound/pci/hda/patch_hdmi.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index b72553710ffb..3c720703ebb8 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -2851,6 +2851,18 @@ static int patch_i915_icl_hdmi(struct hda_codec *codec) return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map)); }
+static int patch_i915_tgl_hdmi(struct hda_codec *codec) +{ + /* + * pin to port mapping table where the value indicate the pin number and + * the index indicate the port number with 1 base. + */ + static const int map[] = {0x4, 0x6, 0x8, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf}; + + return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map)); +} + + /* Intel Baytrail and Braswell; with eld notifier */ static int patch_i915_byt_hdmi(struct hda_codec *codec) { @@ -4153,6 +4165,7 @@ HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi), HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi), HDA_CODEC_ENTRY(0x8086280f, "Icelake HDMI", patch_i915_icl_hdmi), +HDA_CODEC_ENTRY(0x80862812, "Tigerlake HDMI", patch_i915_tgl_hdmi), HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi), HDA_CODEC_ENTRY(0x80862882, "Valleyview2 HDMI", patch_i915_byt_hdmi), HDA_CODEC_ENTRY(0x80862883, "Braswell HDMI", patch_i915_byt_hdmi),
Quoting Kai Vehmanen (2019-11-05 16:10:53)
Add Tigerlake HDMI codec support.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205379 BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=112171 Cc: Pan Xiuli xiuli.pan@linux.intel.com Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com
For thos watching, https://patchwork.freedesktop.org/series/68972/#rev1 includes the revert so that this is tested. Not that the first run through BAT tgl died too early to be conclusive. -Chris
Hi,
On Tue, 5 Nov 2019, Chris Wilson wrote:
Quoting Kai Vehmanen (2019-11-05 16:10:53)
Add Tigerlake HDMI codec support.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205379 BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=112171 Cc: Pan Xiuli xiuli.pan@linux.intel.com Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com
For thos watching, https://patchwork.freedesktop.org/series/68972/#rev1 includes the revert so that this is tested. Not that the first run through BAT tgl died too early to be conclusive.
ack. The partial results do look good already. The boot log shows HDMI codec found and configured without errors: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/boot0.txt
And the S3 suspend test did pass: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/igt@gem_exec_s...
So so far so good.
Br, Kai
On Tue, 05 Nov 2019 17:24:37 +0100, Kai Vehmanen wrote:
Hi,
On Tue, 5 Nov 2019, Chris Wilson wrote:
Quoting Kai Vehmanen (2019-11-05 16:10:53)
Add Tigerlake HDMI codec support.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205379 BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=112171 Cc: Pan Xiuli xiuli.pan@linux.intel.com Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com
For thos watching, https://patchwork.freedesktop.org/series/68972/#rev1 includes the revert so that this is tested. Not that the first run through BAT tgl died too early to be conclusive.
ack. The partial results do look good already. The boot log shows HDMI codec found and configured without errors: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/boot0.txt
And the S3 suspend test did pass: https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/igt@gem_exec_s...
So so far so good.
OK, I applied the patch now. If any correction is needed, please submit a new on top of it.
thanks,
Takashi
participants (3)
-
Chris Wilson
-
Kai Vehmanen
-
Takashi Iwai