[alsa-devel] [PATCH] ALSA: hda - fixup input_free_device called after input_unregister_device
Input_unregister_device will internally free the device, so input_free_device should not be called.
Reported-by: Dan Carpenter dan.carpenter@oracle.com Signed-off-by: David Henningsson david.henningsson@canonical.com --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 09d2131..a50e15e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -3548,7 +3548,6 @@ static void alc280_fixup_hp_gpio2_mic_hotkey(struct hda_codec *codec, break; case HDA_FIXUP_ACT_FREE: input_unregister_device(spec->kb_dev); - input_free_device(spec->kb_dev); spec->kb_dev = NULL; } #endif
At Sat, 10 Jan 2015 13:02:22 +0100, David Henningsson wrote:
Input_unregister_device will internally free the device, so input_free_device should not be called.
Reported-by: Dan Carpenter dan.carpenter@oracle.com Signed-off-by: David Henningsson david.henningsson@canonical.com
Applied, thanks.
Takashi
sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 09d2131..a50e15e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -3548,7 +3548,6 @@ static void alc280_fixup_hp_gpio2_mic_hotkey(struct hda_codec *codec, break; case HDA_FIXUP_ACT_FREE: input_unregister_device(spec->kb_dev);
input_free_device(spec->kb_dev);#endif
1.9.1
participants (2)
-
David Henningsson -
Takashi Iwai