[alsa-devel] [PATCH - quirk for USB Aureon cards 1/1] Add quirk to provide proper naming of the Terratec Aureon 5.1 MkII USB card
Signed-off-by: Andrea Borgia andrea@borgia.bo.it
diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h index 5d955aa..d84d6f3 100644 --- a/sound/usb/usbquirks.h +++ b/sound/usb/usbquirks.h @@ -1951,6 +1951,14 @@ YAMAHA_DEVICE(0x7010, "UB99"), } }, { + USB_DEVICE_VENDOR_SPEC(0x0ccd, 0x0028), + .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { + .vendor_name = "TerraTec", + .product_name = "Aureon 5.1 MkII", + .ifnum = QUIRK_NO_INTERFACE + } +}, +{ USB_DEVICE(0x0ccd, 0x0035), .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { .vendor_name = "Miditech",
At Sun, 31 May 2009 23:06:07 +0200, Andrea Borgia wrote:
[1 <text/plain; ISO-8859-15 (7bit)>]
[2 0001-Add-quirk-to-provide-proper-naming-of-the-Terratec-A.patch <text/x-diff (7bit)>]
Signed-off-by: Andrea Borgia andrea@borgia.bo.it
Applied now. Thanks!
(BTW, it'd be helpful if you write a proper subject line and a changelog in the patch itself at the next time so that I can apply it directly with git-am.)
Takashi
Takashi Iwai ha scritto:
Signed-off-by: Andrea Borgia andrea@borgia.bo.it
Applied now. Thanks!
I fear I might have made a mistake somewhere: after patching, rebuilding and reloading the module the device is still showing up with the generic "Audio" name in /proc/asound/cards
_From the looks of it, would you agree my latest patch works like my earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?
Andrea.
At Tue, 02 Jun 2009 20:39:13 +0200, Andrea Borgia wrote:
Takashi Iwai ha scritto:
Signed-off-by: Andrea Borgia andrea@borgia.bo.it
Applied now. Thanks!
I fear I might have made a mistake somewhere: after patching, rebuilding and reloading the module the device is still showing up with the generic "Audio" name in /proc/asound/cards
From the looks of it, would you agree my latest patch works like my earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?
Hm, doesn't it work properly even after your correction patch?
Takashi
Takashi Iwai ha scritto:
From the looks of it, would you agree my latest patch works like my earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?
Hm, doesn't it work properly even after your correction patch?
It does, sort of... but at least I found out that the patched module wasn't being rebuilt and that was causing the glitch.
Now I get a funny name: "MkII". The full name is ok, but the shorter name in "cards" is not.
What do you suggest in such cases? Remove all spaces, change them to underscores or what else?
A.
At Wed, 03 Jun 2009 15:40:10 +0200, Andrea Borgia wrote:
Takashi Iwai ha scritto:
From the looks of it, would you agree my latest patch works like my earlier one for the Toshiba SB-0500 ? That is, renames the device and nothing else?
Hm, doesn't it work properly even after your correction patch?
It does, sort of... but at least I found out that the patched module wasn't being rebuilt and that was causing the glitch.
Now I get a funny name: "MkII". The full name is ok, but the shorter name in "cards" is not.
What do you suggest in such cases? Remove all spaces, change them to underscores or what else?
Show the whole name strings. I don't know whether it's funny or not unless I see them :)
Takashi
Takashi Iwai ha scritto:
Show the whole name strings. I don't know whether it's funny or not unless I see them :)
-x-x-x- 0 [SIS966 ]: HDA-Intel - HDA SIS966 HDA SIS966 at 0xd4200000 irq 18 1 [MkII ]: USB-Audio - Aureon 5.1 MkII TerraTec Aureon 5.1 MkII at usb-0000:00:03.0-2, full speed -x-x-x-
You see, MkII could be a lot of things, like Colossus or anything ;-)
A.
At Wed, 03 Jun 2009 17:59:34 +0200, Andrea Borgia wrote:
Takashi Iwai ha scritto:
Show the whole name strings. I don't know whether it's funny or not unless I see them :)
-x-x-x- 0 [SIS966 ]: HDA-Intel - HDA SIS966 HDA SIS966 at 0xd4200000 irq 18 1 [MkII ]: USB-Audio - Aureon 5.1 MkII TerraTec Aureon 5.1 MkII at usb-0000:00:03.0-2, full speed -x-x-x-
You see, MkII could be a lot of things, like Colossus or anything ;-)
Well, it's just an id string. The only requirement is to be unique on the running system.
If this name is unacceptable (e.g. it's the name of my ex, it's a patent infringement, or whatever reason), concatenate Aureon 5.1 and MkII to a single word, then you'll get a different one.
Or, you could implement more codes to give a better id string with the API function recently added...
thanks,
Takashi
Takashi Iwai ha scritto:
Well, it's just an id string. The only requirement is to be unique on the running system.
Although highly unlikely in this specific case, how about multiple identical cards on the same host? Does it still hold true?
If this name is unacceptable (e.g. it's the name of my ex, it's a patent infringement, or whatever reason), concatenate Aureon 5.1 and MkII to a single word, then you'll get a different one. Or, you could implement more codes to give a better id string with the API function recently added...
Where should I look for this super snazzy function? I'm curious, I already know how to add a quirk, let's learn something new :-)
Andrea.
participants (2)
-
Andrea Borgia -
Takashi Iwai