On Sun, Aug 14, 2011 at 11:31:04AM +0800, Axel Lin wrote:

There is exactly one match or no match at all during the for loop iteration, thus we can break from the for loop once a match is found.

Signed-off-by: Axel Lin axel.lin@gmail.com

Looks good.

Acked-by: Johannes Stezenbach js@sig21.net

Thanks, Johannes

---

sound/soc/codecs/sta32x.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index fbd7eb9..3d155f5 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -524,13 +524,17 @@ static int sta32x_hw_params(struct snd_pcm_substream *substream, rate = params_rate(params); pr_debug("rate: %u\n", rate); for (i = 0; i < ARRAY_SIZE(interpolation_ratios); i++)

• if (interpolation_ratios[i].fs == rate)
  

• if (interpolation_ratios[i].fs == rate) {
  ir = interpolation_ratios[i].ir;
  

• 	break;
  

• }
  

  if (ir < 0) return -EINVAL; for (i = 0; mclk_ratios[ir][i].ratio; i++)

• if (mclk_ratios[ir][i].ratio * rate == sta32x->mclk)
  

• if (mclk_ratios[ir][i].ratio * rate == sta32x->mclk) {
  mcs = mclk_ratios[ir][i].mcs;
  

• 	break;
  

• }
  

  if (mcs < 0) return -EINVAL;

-- 1.7.4.1