[PATCH v2 0/8] Docs: Add missing SPDX license identifiers of
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Changes from v1 (https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/) - Separate from index file content changes - Separate patch for each subsystem doc (Alex Deucher) - Use MIT license for gpu (Alex Deucher)
SeongJae Park (8): Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
Documentation/crypto/index.rst | 2 ++ Documentation/driver-api/index.rst | 2 ++ Documentation/gpu/index.rst | 2 ++ Documentation/hwmon/index.rst | 2 ++ Documentation/input/index.rst | 2 ++ Documentation/mm/index.rst | 2 ++ Documentation/scheduler/index.rst | 2 ++ Documentation/sound/index.rst | 2 ++ 8 files changed, 16 insertions(+)
Add missing SPDX License Identifier for sound documentation index file.
Signed-off-by: SeongJae Park sj@kernel.org --- Documentation/sound/index.rst | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/sound/index.rst b/Documentation/sound/index.rst index 5abed5fc6485..7e67e12730d3 100644 --- a/Documentation/sound/index.rst +++ b/Documentation/sound/index.rst @@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0 + ============================= Sound Subsystem Documentation =============================
On Sun, 22 Jan 2023 22:36:50 +0100, SeongJae Park wrote:
Add missing SPDX License Identifier for sound documentation index file.
Signed-off-by: SeongJae Park sj@kernel.org
Acked-by: Takashi Iwai tiwai@suse.de
thanks,
Takashi
Documentation/sound/index.rst | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/sound/index.rst b/Documentation/sound/index.rst index 5abed5fc6485..7e67e12730d3 100644 --- a/Documentation/sound/index.rst +++ b/Documentation/sound/index.rst @@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0
============================= Sound Subsystem Documentation ============================= -- 2.25.1
On 1/23/23 02:10, Takashi Iwai wrote:
On Sun, 22 Jan 2023 22:36:50 +0100, SeongJae Park wrote:
Add missing SPDX License Identifier for sound documentation index file.
Signed-off-by: SeongJae Park sj@kernel.org
Acked-by: Takashi Iwai tiwai@suse.de
Isn't GPL-2.0 deprecated? It should be GPL-2.0-only, no?
https://spdx.org/licenses/GPL-2.0.html
https://spdx.org/licenses/GPL-2.0-only.html
thanks,
Takashi
Documentation/sound/index.rst | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/sound/index.rst b/Documentation/sound/index.rst index 5abed5fc6485..7e67e12730d3 100644 --- a/Documentation/sound/index.rst +++ b/Documentation/sound/index.rst @@ -1,3 +1,5 @@ +.. SPDX-License-Identifier: GPL-2.0
============================= Sound Subsystem Documentation ============================= -- 2.25.1
Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com writes:
On 1/23/23 02:10, Takashi Iwai wrote:
On Sun, 22 Jan 2023 22:36:50 +0100, SeongJae Park wrote:
Add missing SPDX License Identifier for sound documentation index file.
Signed-off-by: SeongJae Park sj@kernel.org
Acked-by: Takashi Iwai tiwai@suse.de
Isn't GPL-2.0 deprecated? It should be GPL-2.0-only, no?
The kernel community hasn't really followed along with that change on the part of the SPDX folks; as far as I know, GPL-2.0 is considered to be just fine. There are currently more than twice as many GPL-2.0 declarations than GPL-2.0-only.
Thanks,
jon
SeongJae Park sj@kernel.org writes:
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Documentation/ is far behind on the SPDX front, and I'm all in favor of fixing that. I do worry, though, about sticking license declarations onto files that did not previously have them; do we know what the original contributor's intent was?
Changes from v1 (https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)
SeongJae Park (8): Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
Documentation/crypto/index.rst | 2 ++ Documentation/driver-api/index.rst | 2 ++
I added this one, and GPLv2 is fine there.
Documentation/gpu/index.rst | 2 ++ Documentation/hwmon/index.rst | 2 ++ Documentation/input/index.rst | 2 ++ Documentation/mm/index.rst | 2 ++ Documentation/scheduler/index.rst | 2 ++ Documentation/sound/index.rst | 2 ++ 8 files changed, 16 insertions(+)
Thanks,
jon
SeongJae Park sj@kernel.org writes:
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Changes from v1 (https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)
SeongJae Park (8): Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
So I've applied patches 2 (since I wrote the initial file) and 8 (with Takashi's ack). The others are also fine, I think, but I hesitate to apply license texts to files without knowing that they match the author's intent. I hate to say it, but I think the best approach is to send each of the remaining patches to the appropriate maintainers for the subsystem involved.
Thanks,
jon
On Tue, 24 Jan 2023 15:31:04 -0700 Jonathan Corbet corbet@lwn.net wrote:
SeongJae Park sj@kernel.org writes:
Some subsystem documents are missing SPDX license identifiers on index files. This patchset adds those.
Changes from v1 (https://lore.kernel.org/lkml/20230114194741.115855-2-sj@kernel.org/)
- Separate from index file content changes
- Separate patch for each subsystem doc (Alex Deucher)
- Use MIT license for gpu (Alex Deucher)
SeongJae Park (8): Docs/crypto/index: Add missing SPDX License Identifier Docs/driver-api/index: Add missing SPDX License Identifier Docs/gpu/index: Add missing SPDX License Identifier Docs/hwmon/index: Add missing SPDX License Identifier Docs/input/index: Add missing SPDX License Identifier Docs/mm/index: Add missing SPDX License Identifier Docs/scheduler/index: Add missing SPDX License Identifier Docs/sound/index: Add missing SPDX License Identifier
So I've applied patches 2 (since I wrote the initial file) and 8 (with Takashi's ack). The others are also fine, I think, but I hesitate to apply license texts to files without knowing that they match the author's intent. I hate to say it, but I think the best approach is to send each of the remaining patches to the appropriate maintainers for the subsystem involved.
That makes 100% sense, thank you, Jon!
Thanks, SJ
Thanks,
jon
participants (4)
-
Jonathan Corbet
-
Pierre-Louis Bossart
-
SeongJae Park
-
Takashi Iwai