On Wed, Aug 08, 2012 at 11:34:43AM +0530, Sachin Kamat wrote:

Fixes the following build error: In file included from arch/arm/mach-exynos/include/mach/dma.h:24:0, from arch/arm/plat-samsung/include/plat/dma-ops.h:17, from arch/arm/plat-samsung/include/plat/dma.h:128, from sound/soc/samsung/pcm.c:23: arch/arm/plat-samsung/include/plat/dma-pl330.h:106:8: error: redefinition of ‘struct s3c2410_dma_client’ arch/arm/plat-samsung/include/plat/dma.h:40:8: note: originally defined here make[3]: *** [sound/soc/samsung/pcm.o] Error 1

Shouldn't this be being fixed in the headers? It looks like they reference and disagree with each other on Exynos (my primary development platform is S3C6410 based so I'd notice if it was a generic Samsung issue.

Pasting the error message isn't really that useful unless the fix is obvious, it's better to explain in words what's wrong.