[alsa-devel] [PATCH 1/1] ALSA: oxygen: initialize spdif_playback_enable to 0
From: Tom Yan tom.ty89@gmail.com
There's no reason for us to do that while we initialize dac_mute to 1. Also oxygen_init() has been clearing the OXYGEN_SPDIF_OUT_ENABLE bit anyway.
Signed-off-by: Tom Yan tom.ty89@gmail.com
diff --git a/sound/pci/oxygen/oxygen_lib.c b/sound/pci/oxygen/oxygen_lib.c index b4ef5804212d..6a743c878415 100644 --- a/sound/pci/oxygen/oxygen_lib.c +++ b/sound/pci/oxygen/oxygen_lib.c @@ -373,7 +373,7 @@ static void oxygen_init(struct oxygen *chip) for (i = 0; i < 8; ++i) chip->dac_volume[i] = chip->model.dac_volume_min; chip->dac_mute = 1; - chip->spdif_playback_enable = 1; + chip->spdif_playback_enable = 0; chip->spdif_bits = OXYGEN_SPDIF_C | OXYGEN_SPDIF_ORIGINAL | (IEC958_AES1_CON_PCM_CODER << OXYGEN_SPDIF_CATEGORY_SHIFT); chip->spdif_pcm_bits = chip->spdif_bits;
On Fri, 21 Dec 2018 13:52:57 +0100, tom.ty89@gmail.com wrote:
From: Tom Yan tom.ty89@gmail.com
There's no reason for us to do that while we initialize dac_mute to
- Also oxygen_init() has been clearing the OXYGEN_SPDIF_OUT_ENABLE
bit anyway.
Signed-off-by: Tom Yan tom.ty89@gmail.com
Applied for 5.1 now. Thanks.
Takashi
participants (2)
-
Takashi Iwai
-
tom.ty89@gmail.com