[alsa-devel] [PATCHv3 3/4] Add ASoC support for DevKit8000

This patch expands the omap3beagle sound soc for the beagle board clone Devkit8000.
Change log V2 Expand omap3beagle sound soc for DevKit8000 support. V3 Separate Kconfig for Devkit8000.
Signed-off-by: Thomas Weber swirl@gmx.li --- sound/soc/omap/Kconfig | 8 ++++++++ sound/soc/omap/Makefile | 1 + sound/soc/omap/omap3beagle.c | 6 +++--- 3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 61952aa..8520b75 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -101,6 +101,14 @@ config SND_OMAP_SOC_OMAP3_BEAGLE help Say Y if you want to add support for SoC audio on the Beagleboard.
+config SND_OMAP_SOC_DEVKIT8000 + tristate "SoC Audio support for DevKit8000" + depends on TWL4030_CORE && SND_OMAP_SOC && MACH_DEVKIT8000 + select SND_OMAP_SOC_MCBSP + select SND_SOC_TWL4030 + help + Say Y if you want to add support for SoC audio on the DevKit8000 + config SND_OMAP_SOC_ZOOM2 tristate "SoC Audio support for Zoom2" depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP_ZOOM2 diff --git a/sound/soc/omap/Makefile b/sound/soc/omap/Makefile index 19283e5..c8195c9 100644 --- a/sound/soc/omap/Makefile +++ b/sound/soc/omap/Makefile @@ -29,5 +29,6 @@ obj-$(CONFIG_SND_OMAP_SOC_AM3517EVM) += snd-soc-am3517evm.o obj-$(CONFIG_SND_OMAP_SOC_SDP3430) += snd-soc-sdp3430.o obj-$(CONFIG_SND_OMAP_SOC_OMAP3_PANDORA) += snd-soc-omap3pandora.o obj-$(CONFIG_SND_OMAP_SOC_OMAP3_BEAGLE) += snd-soc-omap3beagle.o +obj-$(CONFIG_SND_OMAP_SOC_DEVKIT8000) += snd-soc-omap3beagle.o obj-$(CONFIG_SND_OMAP_SOC_ZOOM2) += snd-soc-zoom2.o obj-$(CONFIG_SND_OMAP_SOC_IGEP0020) += snd-soc-igep0020.o diff --git a/sound/soc/omap/omap3beagle.c b/sound/soc/omap/omap3beagle.c index d88ad5c..240e097 100644 --- a/sound/soc/omap/omap3beagle.c +++ b/sound/soc/omap/omap3beagle.c @@ -117,11 +117,11 @@ static int __init omap3beagle_soc_init(void) { int ret;
- if (!machine_is_omap3_beagle()) { - pr_debug("Not OMAP3 Beagle!\n"); + if (!(machine_is_omap3_beagle() || machine_is_devkit8000())) { + pr_debug("Not OMAP3 Beagle or Devkit8000!\n"); return -ENODEV; } - pr_info("OMAP3 Beagle SoC init\n"); + pr_info("OMAP3 Beagle/Devkit8000 SoC init\n");
omap3beagle_snd_device = platform_device_alloc("soc-audio", -1); if (!omap3beagle_snd_device) {

On Wed, 2010-02-10 at 20:23 +0100, Thomas Weber wrote:
This patch expands the omap3beagle sound soc for the beagle board clone Devkit8000.
Change log V2 Expand omap3beagle sound soc for DevKit8000 support. V3 Separate Kconfig for Devkit8000.
Signed-off-by: Thomas Weber swirl@gmx.li
sound/soc/omap/Kconfig | 8 ++++++++ sound/soc/omap/Makefile | 1 + sound/soc/omap/omap3beagle.c | 6 +++--- 3 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 61952aa..8520b75 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -101,6 +101,14 @@ config SND_OMAP_SOC_OMAP3_BEAGLE help Say Y if you want to add support for SoC audio on the Beagleboard.
+config SND_OMAP_SOC_DEVKIT8000
- tristate "SoC Audio support for DevKit8000"
- depends on TWL4030_CORE && SND_OMAP_SOC && MACH_DEVKIT8000
- select SND_OMAP_SOC_MCBSP
- select SND_SOC_TWL4030
- help
Say Y if you want to add support for SoC audio on the DevKit8000
Since this shares the same mach driver as beagle you should share the Kconfig option too (like the Overo).
Thanks
Liam

On Thu, 11 Feb 2010 09:55:12 +0000 Liam Girdwood lrg@slimlogic.co.uk wrote:
Since this shares the same mach driver as beagle you should share the Kconfig option too (like the Overo).
Heh, I had just an opposite view :-)
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-February/025124.ht...

On Thu, 2010-02-11 at 12:40 +0200, Jarkko Nikula wrote:
On Thu, 11 Feb 2010 09:55:12 +0000 Liam Girdwood lrg@slimlogic.co.uk wrote:
Since this shares the same mach driver as beagle you should share the Kconfig option too (like the Overo).
Heh, I had just an opposite view :-)
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-February/025124.ht...
Heh, didn't see that. ;)
I do agree this makes good sense for boards that are very similar and have different audio options/config, but in this case the ASoC mach drivers are identical (atm). Imo it just makes more sense to keep the one Kconfig.
Liam

On Thu, 11 Feb 2010 10:49:48 +0000 Liam Girdwood lrg@slimlogic.co.uk wrote:
I do agree this makes good sense for boards that are very similar and have different audio options/config, but in this case the ASoC mach drivers are identical (atm). Imo it just makes more sense to keep the one Kconfig.
Yeah, after thinking twice, we don't have zillions of options for e.g. Intel HDA either. If we ever figure out some common OMAP+TWL4030 driver, the defconfigs are anyway have to modify so it's better stay with the original patch:
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-February/025129.ht...
Sorry about line noise, Thomas :-)

On Thu, Feb 11, 2010 at 01:14:18PM +0200, Jarkko Nikula wrote:
Yeah, after thinking twice, we don't have zillions of options for e.g. Intel HDA either. If we ever figure out some common OMAP+TWL4030 driver, the defconfigs are anyway have to modify so it's better stay with the original patch:
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-February/025129.ht...
Sorry about line noise, Thomas :-)
Thomas, please resend the patch CCing the relevant maintainers (ie, myself and Liam) - you should always CC maintainers on patch submissions.

On Thursday 11 February 2010 13:14:18 ext Jarkko Nikula wrote:
On Thu, 11 Feb 2010 10:49:48 +0000
Liam Girdwood lrg@slimlogic.co.uk wrote:
I do agree this makes good sense for boards that are very similar and have different audio options/config, but in this case the ASoC mach drivers are identical (atm). Imo it just makes more sense to keep the one Kconfig.
Yeah, after thinking twice, we don't have zillions of options for e.g. Intel HDA either. If we ever figure out some common OMAP+TWL4030 driver, the defconfigs are anyway have to modify so it's better stay with the original patch:
Well, I really doubt that we can find a way to have a common driver for this combination. You can attach quite a big variety of amps to the outputs (some controlled with GPIO, some like the tpa6130 has i2c interface, etc). To have some kind of "infrastructure" to support all of the possible scenarios is just does not worth the effort IMHO.
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-February/025129.h tml
Sorry about line noise, Thomas :-)

On Thu, Feb 11, 2010 at 05:02:54PM +0200, Peter Ujfalusi wrote:
On Thursday 11 February 2010 13:14:18 ext Jarkko Nikula wrote:
Yeah, after thinking twice, we don't have zillions of options for e.g. Intel HDA either. If we ever figure out some common OMAP+TWL4030
Well, I really doubt that we can find a way to have a common driver for this combination. You can attach quite a big variety of amps to the outputs (some controlled with GPIO, some like the tpa6130 has i2c interface, etc). To have some kind of "infrastructure" to support all of the possible scenarios is just does not worth the effort IMHO.
On the other hand there's probably going to be a bunch of boards which can use the same driver by virtue of having copied the audio subsystem en masse from one of the reference designs.
participants (5)
-
Jarkko Nikula
-
Liam Girdwood
-
Mark Brown
-
Peter Ujfalusi
-
Thomas Weber