Re: [alsa-devel] [PATCH] rme96 Add missing vmalloc.h inclusion
At Thu, 22 Aug 2013 15:06:38 +0200, Knut Petersen wrote:
[1 <text/plain; ISO-8859-1 (7bit)>] On 22.08.2013 10:53, Takashi Iwai wrote:
Actually this triggers the double free. It's freed in snd_rme96_free() via snd_card_free().
Yes. Now I see that.
I applied the patch with removal of this double vfree call.
Thanks.
Unfortunately there still is a problem with the code: vmalloc() and vfree() were used without inclusion of linux/vmalloc.h.
Indeed. Applied now. Thanks.
Takashi
cu, Knut
[2 0001-alsa-rme96-Add-missing-inclusion-of-linux-vmalloc.h.patch <text/x-patch (7bit)>]
From 2a3f98ff69308f3c2ee508ac0887e1f8bf493d64 Mon Sep 17 00:00:00 2001
From: Knut Petersen Knut_Petersen@t-online.de Date: Thu, 22 Aug 2013 14:36:16 +0200 Subject: [PATCH] alsa/rme96: Add missing inclusion of linux/vmalloc.h
Signed-off-by: Knut Petersen Knut_Petersen@t-online.de
sound/pci/rme96.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/rme96.c b/sound/pci/rme96.c index 2acf565..cc6deca 100644 --- a/sound/pci/rme96.c +++ b/sound/pci/rme96.c @@ -28,6 +28,7 @@ #include <linux/interrupt.h> #include <linux/pci.h> #include <linux/module.h> +#include <linux/vmalloc.h>
#include <sound/core.h>
#include <sound/info.h>
1.8.1.4
participants (1)
-
Takashi Iwai