[alsa-devel] [PATCH] ASoC: WM8580: Fix R8 initial value
From: Seungwhan Youn sw.youn@samsung.com
Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
Signed-off-by: Seungwhan Youn sw.youn@samsung.com --- sound/soc/codecs/wm8580.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c index 6e95332..6be373d 100644 --- a/sound/soc/codecs/wm8580.c +++ b/sound/soc/codecs/wm8580.c @@ -179,7 +179,7 @@ static const u16 wm8580_reg[] = { 0x0121, 0x017e, 0x007d, 0x0014, /*R3*/ 0x0121, 0x017e, 0x007d, 0x0194, /*R7*/ - 0x001c, 0x0002, 0x0002, 0x00c2, /*R11*/ + 0x0010, 0x0002, 0x0002, 0x00c2, /*R11*/ 0x0182, 0x0082, 0x000a, 0x0024, /*R15*/ 0x0009, 0x0000, 0x00ff, 0x0000, /*R19*/ 0x00ff, 0x00ff, 0x00ff, 0x00ff, /*R23*/
On Thu, 2010-12-09 at 18:07 +0900, Jassi Brar wrote:
From: Seungwhan Youn sw.youn@samsung.com
Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
Signed-off-by: Seungwhan Youn sw.youn@samsung.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
On Thu, Dec 09, 2010 at 06:07:52PM +0900, Jassi Brar wrote:
From: Seungwhan Youn sw.youn@samsung.com
Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
Signed-off-by: Seungwhan Youn sw.youn@samsung.com
You really should include your signoff in patches when sending ones written by other people to say that you're certifying that the patch is legally OK to submit - that's what the signoff stuff is about, it's about saying that you take responsibility for the patch.
In this case it's not so important as it's a trivially obvious fix so probably below the individually copyrightable threashold anyway so I've applied.
On Thu, Dec 9, 2010 at 8:00 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Thu, Dec 09, 2010 at 06:07:52PM +0900, Jassi Brar wrote:
From: Seungwhan Youn sw.youn@samsung.com
Acc to WM8580 manual, the default value for R8 is 0x10, not 0x1c.
Signed-off-by: Seungwhan Youn sw.youn@samsung.com
You really should include your signoff in patches when sending ones written by other people to say that you're certifying that the patch is legally OK to submit - that's what the signoff stuff is about, it's about saying that you take responsibility for the patch.
Ok, will take care in future. Thanks.
participants (4)
-
Jassi Brar -
Jassi Brar -
Liam Girdwood -
Mark Brown