[alsa-devel] [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support
This patch is to add support for rockchip board with max98090 codec. It also needs sound node in dt file.
Tested on rockchip board based on rk3288.
Signed-off-by: Jianqun jay.xu@rock-chips.com --- sound/soc/rockchip/Kconfig | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 78fc159..482cbba 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -9,3 +9,16 @@ config SND_SOC_ROCKCHIP
config SND_SOC_ROCKCHIP_I2S tristate + depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP + help + Say Y or M if you want to add support for I2S driver for Rockchip + I2S device. + +config SND_SOC_ROCKCHIP_MAX98090 + tristate "ASoC support Rockchip board with max98090" + depends on I2C && GPIOLIB + select SND_SOC_ROCKCHIP_I2S + select SND_SOC_MAX98090 + help + Say Y or M here if you want to add support for Rockchio board using + a max98090 codec.
On 10/21/2014 01:31 PM, Jianqun wrote:
This patch is to add support for rockchip board with max98090 codec. It also needs sound node in dt file.
Tested on rockchip board based on rk3288.
Signed-off-by: Jianqun jay.xu@rock-chips.com
sound/soc/rockchip/Kconfig | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 78fc159..482cbba 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -9,3 +9,16 @@ config SND_SOC_ROCKCHIP
config SND_SOC_ROCKCHIP_I2S tristate
- depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
- help
Say Y or M if you want to add support for I2S driver for RockchipI2S device.+config SND_SOC_ROCKCHIP_MAX98090
- tristate "ASoC support Rockchip board with max98090"
- depends on I2C && GPIOLIB
- select SND_SOC_ROCKCHIP_I2S
- select SND_SOC_MAX98090
- help
Say Y or M here if you want to add support for Rockchio board usinga max98090 codec.
Just make the max98090 driver directly selectable. That's what we typically do for DT based designs.
- Lars
This patch is to add support for rockchip board with max98090 codec. It also needs sound node in dt file.
Tested on rockchip board based on rk3288.
Signed-off-by: Jianqun jay.xu@rock-chips.com --- change since v1: -Just make the max98090 driver directly selectable, suggested by Lars
sound/soc/rockchip/Kconfig | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 78fc159..230b0e9 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -9,3 +9,15 @@ config SND_SOC_ROCKCHIP
config SND_SOC_ROCKCHIP_I2S tristate + depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP + help + Say Y or M if you want to add support for I2S driver for Rockchip + I2S device. + +config SND_SOC_MAX98090 + tristate "ASoC support max98090 device driver" + depends on I2C && GPIOLIB + select SND_SOC_ROCKCHIP_I2S + help + Say Y or M here if you want to add support for Rockchio board using + a max98090 codec.
On Wed, Oct 22, 2014 at 08:40:56AM +0800, Jianqun wrote:
config SND_SOC_ROCKCHIP_I2S tristate
- depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
- help
Say Y or M if you want to add support for I2S driver for RockchipI2S device.
You need to make this directlyuser selectable by adding some text after the tristate as well as the rest.
+config SND_SOC_MAX98090
- tristate "ASoC support max98090 device driver"
- depends on I2C && GPIOLIB
- select SND_SOC_ROCKCHIP_I2S
- help
Say Y or M here if you want to add support for Rockchio board usinga max98090 codec.
This needs to modify the existing MAX98090 entry, not duplicate it (probably as a separate patch).
Add SND_SOC_MAX98090 to Kconfig of rockchip ASoC, to support rockchip board using a max98090 codec.
Tested on rockchip board based on rk3288.
Signed-off-by: Jianqun jay.xu@rock-chips.com --- changes since v1: --make the max98090 driver directly selectable, suggested by Lars
changes since v2: --modify tristate infomation for SND_SOC_ROCKCHIP --make SND_SOC_MAX98090 not depends on SND_SOC_ROCKCHIP
sound/soc/rockchip/Kconfig | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 78fc159..236500e 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -1,5 +1,5 @@ config SND_SOC_ROCKCHIP - tristate "ASoC support for Rockchip" + tristate "SoC Audio for the Rockchip System-on-Chip" depends on COMPILE_TEST || ARCH_ROCKCHIP select SND_SOC_GENERIC_DMAENGINE_PCM help @@ -8,4 +8,14 @@ config SND_SOC_ROCKCHIP select the audio interfaces to support below.
config SND_SOC_ROCKCHIP_I2S - tristate + tristate "ASoC support for Rockchip I2S driver" + depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP + help + Say Y or M if you want to add support for I2S driver for Rockchip + I2S device. + +config SND_SOC_MAX98090 + tristate "ASoC support for max98090 driver" + depends on I2C && GPIOLIB + help + Say Y or M here if you want to add support for max98090 codec.
On Wed, Oct 22, 2014 at 10:59:59AM +0800, Jianqun wrote:
+config SND_SOC_MAX98090
- tristate "ASoC support for max98090 driver"
- depends on I2C && GPIOLIB
- help
Say Y or M here if you want to add support for max98090 codec.
No, you're missing what Lars was saying here - there's already a Kconfig symbol for the CODEC in the codecs directory, you should add the help text to that in order to allow the user to enable it. Do this in a separate patch to making your I2S driver selectable since it's not directly related code wise.
Please also drop the "ASoC" -> "SoC audio" transition or at least make it a separate patch.
For SND_SOC_ROCKCHIP_I2S, adding some text after the tristate to make this directly user selectable.
Signed-off-by: Jianqun jay.xu@rock-chips.com --- changes since v1: -to make this directlyuser selectable by adding some text after the tristate as well as the rest, suggested by Mark -to use the existing MAX98090 entry, not duplicate it, so remove related codes, suggested by Mark
sound/soc/rockchip/Kconfig | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sound/soc/rockchip/Kconfig b/sound/soc/rockchip/Kconfig index 78fc159..b1fc0ca 100644 --- a/sound/soc/rockchip/Kconfig +++ b/sound/soc/rockchip/Kconfig @@ -8,4 +8,9 @@ config SND_SOC_ROCKCHIP select the audio interfaces to support below.
config SND_SOC_ROCKCHIP_I2S - tristate + tristate "Rockchip I2S Device Driver" + depends on CLKDEV_LOOKUP + help + Say Y or M if you want to add support for I2S driver for + Rockchip I2S device. The device supports upto maximum of + 8 channels each for play and record.
On Sat, Nov 01, 2014 at 10:58:18AM +0800, Jianqun wrote:
For SND_SOC_ROCKCHIP_I2S, adding some text after the tristate to make this directly user selectable.
Applied, thanks.
participants (3)
-
Jianqun -
Lars-Peter Clausen -
Mark Brown