[alsa-devel] [PATCH v2 12/12] dt-bindings: Add documentation for Rockchip dw-hdmi-audio
Required properties: - compatible: platform specific - cpu-of-node: the device node of cpu_dai
Signed-off-by: Yakir Yang ykk@rock-chips.com --- Changes in v2: - remove codec-name and codec-dai-name - rename rockchip,rockchip-hdmi-audio.txt to rockchip,rockchip-dw-hdmi-audio.txt
.../bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt b/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt new file mode 100644 index 0000000..5b86eed --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt @@ -0,0 +1,12 @@ +Rockchip hdmi audio bindings + +Required properties: +- compatible: platform specific +- cpu-of-node: the device node of cpu_dai + +Example: + +sound { + compatible = "rockchip,rk3288-hdmi-audio"; + cpu-of-node = <&i2s>; +};
On Fri, Jan 30, 2015 at 06:44:13AM -0500, Yakir Yang wrote:
Required properties:
- compatible: platform specific
- cpu-of-node: the device node of cpu_dai
Signed-off-by: Yakir Yang ykk@rock-chips.com
Changes in v2:
- remove codec-name and codec-dai-name
- rename rockchip,rockchip-hdmi-audio.txt to rockchip,rockchip-dw-hdmi-audio.txt
.../bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt b/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt new file mode 100644 index 0000000..5b86eed --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt @@ -0,0 +1,12 @@ +Rockchip hdmi audio bindings
+Required properties: +- compatible: platform specific +- cpu-of-node: the device node of cpu_dai
+Example:
+sound {
- compatible = "rockchip,rk3288-hdmi-audio";
- cpu-of-node = <&i2s>;
+};
In patch 11, it looks like you parse a property called i2s-controller. This doesn't appear to be documented. Maybe it's what you call "cpu-of-node" above?
On 01/31/2015 06:36 AM, Russell King - ARM Linux wrote:
On Fri, Jan 30, 2015 at 06:44:13AM -0500, Yakir Yang wrote:
Required properties:
- compatible: platform specific
- cpu-of-node: the device node of cpu_dai
Signed-off-by: Yakir Yang ykk@rock-chips.com
Changes in v2:
remove codec-name and codec-dai-name
rename rockchip,rockchip-hdmi-audio.txt to rockchip,rockchip-dw-hdmi-audio.txt
.../bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt b/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt new file mode 100644 index 0000000..5b86eed --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rockchip,rockchip-dw-hdmi-audio.txt @@ -0,0 +1,12 @@ +Rockchip hdmi audio bindings
+Required properties: +- compatible: platform specific +- cpu-of-node: the device node of cpu_dai
+Example:
+sound {
- compatible = "rockchip,rk3288-hdmi-audio";
- cpu-of-node = <&i2s>;
+};
In patch 11, it looks like you parse a property called i2s-controller. This doesn't appear to be documented. Maybe it's what you call "cpu-of-node" above?
Mistaken, i will modify dt-bings in next version v3.
Thanks for your kindness remind. : )
participants (3)
-
Russell King - ARM Linux
-
Yakir Yang
-
Yang Kuankuan