[alsa-devel] [PATCH] ASoC: adau1701: Initialize codec->control_data before using it
Currently codec->control_data is not initialized before calling process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/codecs/adau1701.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index b7e4cc7..8b7e1c5 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec) int ret;
codec->dapm.idle_bias_off = 1; + codec->control_data = to_i2c_client(codec->dev);
ret = adau1701_load_firmware(codec); if (ret)
2011/9/28 Axel Lin axel.lin@gmail.com:
Currently codec->control_data is not initialized before calling process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).
Signed-off-by: Axel Lin axel.lin@gmail.com
This one is a v2 of original patch. Sorry, forgot to add v2 in the subject line.
sound/soc/codecs/adau1701.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index b7e4cc7..8b7e1c5 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec) int ret;
codec->dapm.idle_bias_off = 1;
- codec->control_data = to_i2c_client(codec->dev);
ret = adau1701_load_firmware(codec); if (ret) -- 1.7.4.1
On 09/28/2011 09:21 AM, Axel Lin wrote:
Currently codec->control_data is not initialized before calling process_sigma_firmware(codec->control_data, ADAU1701_FIRMWARE).
Signed-off-by: Axel Lin axel.lin@gmail.com
Acked-by: Lars-Peter Clausen lars@metafoo.de
Thanks
sound/soc/codecs/adau1701.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index b7e4cc7..8b7e1c5 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -458,6 +458,7 @@ static int adau1701_probe(struct snd_soc_codec *codec) int ret;
codec->dapm.idle_bias_off = 1;
codec->control_data = to_i2c_client(codec->dev);
ret = adau1701_load_firmware(codec); if (ret)
participants (2)
-
Axel Lin -
Lars-Peter Clausen