Re: [alsa-devel] Query about regmap SPI
On Tue, 2012-03-06 at 20:15 +0530, Ashish Chavan wrote:
On Tue, Mar 06, 2012 at 12:53:51PM +0500, Ashish Chavan wrote:
Please always CC the relevant mailing lists on postings. I shouldn't need to remind you about this stuff.
Yes, I agree :-( It's my mistake that I missed linux-kernel@vger.kernel.org
No, implementing stuff like this in individual device drivers rather defeats the point of having frameworks. It sounds like it should be trivial to add support for this to regmap.
I also think that there should be a way to handle this kind of stuff by the framework. May I know if you have any plan to add this to regmap? or should I come up with a patch to extend regmap to support this and propose you?
On Tue, Mar 06, 2012 at 08:38:52PM +0530, Ashish Chavan wrote:
I also think that there should be a way to handle this kind of stuff by the framework. May I know if you have any plan to add this to regmap? or should I come up with a patch to extend regmap to support this and propose you?
I have no need for it so I'm unlikely to work on it myself, if you were to send a patch that'd be great.
On Tue, 2012-03-06 at 16:30 +0000, Mark Brown wrote:
On Tue, Mar 06, 2012 at 08:38:52PM +0530, Ashish Chavan wrote:
I also think that there should be a way to handle this kind of stuff by the framework. May I know if you have any plan to add this to regmap? or should I come up with a patch to extend regmap to support this and propose you?
I have no need for it so I'm unlikely to work on it myself, if you were to send a patch that'd be great.
OK, I will go through regmap sources in detail to find out appropriate place to put this. BTW do you have any recommendation in terms of a good way to achieve this. e.g. will it be useful and generic enough if we introduce two more fields like read/write_flag_mask to indicate shifting and use those fields before applying read/write_flag_masks?
On Tue, Mar 06, 2012 at 11:04:12PM +0530, Ashish Chavan wrote:
place to put this. BTW do you have any recommendation in terms of a good way to achieve this. e.g. will it be useful and generic enough if we introduce two more fields like read/write_flag_mask to indicate shifting and use those fields before applying read/write_flag_masks?
That sounds like a sensible approach.
participants (2)
-
Ashish Chavan -
Mark Brown