[PATCH next] ASoC: cs35l56: Remove redundant return statement in cs35l56_spi_probe()
We have unreachable 'return ret' statement in cs35l56_spi_probe(), delete it as its dead code..
This is found by static analysis with smatch.
Fixes: e49611252900 ("ASoC: cs35l56: Add driver for Cirrus Logic CS35L56") Signed-off-by: Harshit Mogalapalli harshit.m.mogalapalli@oracle.com --- Only compile tested. --- sound/soc/codecs/cs35l56-spi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l56-spi.c b/sound/soc/codecs/cs35l56-spi.c index 80dcf37daae2..4b2084e85f29 100644 --- a/sound/soc/codecs/cs35l56-spi.c +++ b/sound/soc/codecs/cs35l56-spi.c @@ -29,7 +29,6 @@ static int cs35l56_spi_probe(struct spi_device *spi) if (IS_ERR(cs35l56->regmap)) { ret = PTR_ERR(cs35l56->regmap); return dev_err_probe(&spi->dev, ret, "Failed to allocate register map\n"); - return ret; }
cs35l56->dev = &spi->dev;
On 24/03/2023 14:55, Harshit Mogalapalli wrote:
We have unreachable 'return ret' statement in cs35l56_spi_probe(), delete it as its dead code..
This is found by static analysis with smatch.
Fixes: e49611252900 ("ASoC: cs35l56: Add driver for Cirrus Logic CS35L56") Signed-off-by: Harshit Mogalapalli harshit.m.mogalapalli@oracle.com
Only compile tested.
sound/soc/codecs/cs35l56-spi.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l56-spi.c b/sound/soc/codecs/cs35l56-spi.c index 80dcf37daae2..4b2084e85f29 100644 --- a/sound/soc/codecs/cs35l56-spi.c +++ b/sound/soc/codecs/cs35l56-spi.c @@ -29,7 +29,6 @@ static int cs35l56_spi_probe(struct spi_device *spi) if (IS_ERR(cs35l56->regmap)) { ret = PTR_ERR(cs35l56->regmap); return dev_err_probe(&spi->dev, ret, "Failed to allocate register map\n");
return ret;}
cs35l56->dev = &spi->dev;
Reviewed-by: Richard Fitzgerald rf@opensource.cirrus.com
On Fri, 24 Mar 2023 07:55:35 -0700, Harshit Mogalapalli wrote:
We have unreachable 'return ret' statement in cs35l56_spi_probe(), delete it as its dead code..
This is found by static analysis with smatch.
Applied to
broonie/sound.git for-next
Thanks!
[1/1] ASoC: cs35l56: Remove redundant return statement in cs35l56_spi_probe() commit: 283771e8eefcbe4a0a84c6a00a0b7a210bbc5846
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Harshit Mogalapalli -
Mark Brown -
Richard Fitzgerald