[alsa-devel] [PATCH 2/2] ALSA: hda - Sleep for 10ms after entering D3 on Conexant codecs
On rare occasions, we are still noticing that the internal speaker spitting out spurious noises even after adding the problematic codec to the list.
Adding a 10ms artificial delay before rebooting fixes the issue entirely.
Patch for Realtek codecs also adds the same amount of delay after entering D3.
Signed-off-by: Park Ju Hyung qkrwngud825@gmail.com Cc: stable@vger.kernel.org --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 909a880f5e01..1a8a2d440fbd 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -226,6 +226,7 @@ static void cx_auto_reboot_notify(struct hda_codec *codec) snd_hda_codec_set_power_to_all(codec, codec->core.afg, AC_PWRST_D3); snd_hda_codec_write(codec, codec->core.afg, 0, AC_VERB_SET_POWER_STATE, AC_PWRST_D3); + msleep(10); }
static void cx_auto_free(struct hda_codec *codec)
On Fri, 27 Jul 2018 20:16:42 +0200, Park Ju Hyung wrote:
On rare occasions, we are still noticing that the internal speaker spitting out spurious noises even after adding the problematic codec to the list.
Adding a 10ms artificial delay before rebooting fixes the issue entirely.
Patch for Realtek codecs also adds the same amount of delay after entering D3.
Signed-off-by: Park Ju Hyung qkrwngud825@gmail.com Cc: stable@vger.kernel.org
Applied, thanks.
Takashi
participants (2)
-
Park Ju Hyung
-
Takashi Iwai