On Tue, 15 Mar 2022 06:28:05 +0100, Xu, Yang wrote:

Hi Mark and Takashi Iwai,

This is Raphael Xu who is from Low Power Audio team,Texas Instrument.

Could you help to review the attached patch and upstream them to the kernel?

Thanks for the patches, but could you prepare the proper patches and submit in a better way? The details about how to submit patches are found in Documentation/process/submitting-patches.rst.

It seems that you sent a diff from each file, but it's no proper patch. I guess it'll be a single patch containing all files in your case.

Also, above all, describe why and what you added / modified the code concisely but well understandably in the patch description (commit log).

Drop the kernel version check with #if LINUX_VERSION. This must not be in the upstream code.

Last but not least, don't forget to put your Signed-off-by tag. It's a legal requirement. Again, see the document above for details.

thanks,

Takashi