On Mon, Mar 29, 2021 at 9:54 PM Jack Yu jack.yu@realtek.com wrote:

...

-----Original Message----- From: Mark Brown broonie@kernel.org Sent: Monday, March 29, 2021 11:37 PM To: Jack Yu jack.yu@realtek.com Cc: Rob Herring robh@kernel.org; lgirdwood@gmail.com; Oder Chiou oder_chiou@realtek.com; alsa-devel@alsa-project.org; lars@metafoo.de; kent_chen@realtek.com [陳建宏] kent_chen@realtek.com; 陳昶志 kenny_chen@realtek.com; Derek [方德義] derek.fang@realtek.com; Shuming [范書銘] shumingf@realtek.com; Flove(HsinFu) flove@realtek.com Subject: Re: [PATCH v2] ASoC: rt1019: add rt1019 amplifier driver

On Mon, Mar 29, 2021 at 08:09:26AM +0000, Jack Yu wrote:

...

...

Bindings should also be sent to the DT list. get_maintainer.pl will tell you

this.

...

1. Does it mean I should add my name in MAINTAINERS?

It means you should have sent the patch with the binding changes to the DT list and maintainers as well as everyone else.

...

2. Is below warning message caused by #1 question?

No, it's the content of the change that's introduced problems in the binding.

Hi Mark,

I'll add below "address-cells" and "size-cells " in to rt1019.yaml like below

examples:

• | i2c {

•    #address-cells = <1>;
  

•    #size-cells = <0>;
    rt1019: codec@28 {
        compatible = "realtek,rt1019";
        reg = <0x28>;
    };
  

  };

but I'm not sure how to fix some of below warnings, like 'reg_format' and 'i2c_bus_bridge' and 'avoid_default_addr_size', are these caused by lack of "address-cells" and "size-cells "?

Yes, but run 'make dt_binding_check' to make sure.

Rob