[alsa-devel] [PATCH] sound: soc: samsung: neo1973_wm8753: remove references to machine_is_neo1973_gta01
The Openmoko GTA01 machine has been removed from the machine ID database, so we need to remove references to it as well.
Without that fix we have: sound/soc/samsung/neo1973_wm8753.c: In function ‘neo1973_wm8753_init’: sound/soc/samsung/neo1973_wm8753.c:325:2: error: implicit declaration of function ‘machine_is_neo1973_gta01’
Signed-off-by: Denis 'GNUtoo' Carikli GNUtoo@no-log.org --- sound/soc/samsung/neo1973_wm8753.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/sound/soc/samsung/neo1973_wm8753.c b/sound/soc/samsung/neo1973_wm8753.c index 7207189..4d35297 100644 --- a/sound/soc/samsung/neo1973_wm8753.c +++ b/sound/soc/samsung/neo1973_wm8753.c @@ -322,10 +322,6 @@ static int neo1973_wm8753_init(struct snd_soc_pcm_runtime *rtd) int ret;
/* set up NC codec pins */ - if (machine_is_neo1973_gta01()) { - snd_soc_dapm_nc_pin(dapm, "LOUT2"); - snd_soc_dapm_nc_pin(dapm, "ROUT2"); - } snd_soc_dapm_nc_pin(dapm, "OUT3"); snd_soc_dapm_nc_pin(dapm, "OUT4"); snd_soc_dapm_nc_pin(dapm, "LINE1"); @@ -479,7 +475,7 @@ static int __init neo1973_init(void) { int ret;
- if (!machine_is_neo1973_gta01() && !machine_is_neo1973_gta02()) + if (!machine_is_neo1973_gta02()) return -ENODEV;
if (machine_is_neo1973_gta02()) {
Hi,
On Sun, Dec 04, 2011 at 08:06PM, Denis 'GNUtoo' Carikli wrote:
The Openmoko GTA01 machine has been removed from the machine ID database, so we need to remove references to it as well.
Without that fix we have: sound/soc/samsung/neo1973_wm8753.c: In function ‘neo1973_wm8753_init’: sound/soc/samsung/neo1973_wm8753.c:325:2: error: implicit declaration of function ‘machine_is_neo1973_gta01’
This issue is discussed on the last September. https://lkml.org/lkml/2011/9/14/66
Russell said that GTA01 is dead platform. And I think that It is desirable to remove on mainline. Mark, Is there any issue?
Thanks, Sangbeom
On Tue, Dec 06, 2011 at 06:38:42PM +0900, Sangbeom Kim wrote:
Russell said that GTA01 is dead platform. And I think that It is desirable to remove on mainline. Mark, Is there any issue?
Someone should ping the OpenMoko guys before we do this.
participants (3)
-
Denis 'GNUtoo' Carikli
-
Mark Brown
-
Sangbeom Kim