Re: [alsa-devel] [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s
On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna padma.v@samsung.com wrote:
Add support for device based discovery.
Signed-off-by: Padmavathi Venna padma.v@samsung.com
.../devicetree/bindings/sound/samsung-i2s.txt | 75 +++++++ sound/soc/samsung/dma.c | 1 + sound/soc/samsung/dma.h | 1 + sound/soc/samsung/i2s.c | 233 ++++++++++++++++---- 4 files changed, 269 insertions(+), 41 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/samsung-i2s.txt
diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.txt b/Documentation/devicetree/bindings/sound/samsung-i2s.txt new file mode 100644 index 0000000..bff47b4 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.txt @@ -0,0 +1,75 @@ +* Samsung I2S controller
+Required SoC Specific Properties:
+- compatible : "samsung,samsung-i2s"
Isn't that kind of redundant? :-)
The format of the compatible strings should be "<vendor>,<part-number>-i2s". Please be specific about the part number that you're doing the binding for. For example; use "samsung,exynos4210-i2s" instead of "samsung,exynos-i2s".
+- reg: physical base address of the controller and length of memory mapped
- region.
+[PRELIMINARY: the dma channel allocation will change once there are +official DMA bindings]
+- tx-dma-channel-secondary: The dma channel specifier for secondary tx
- operations. The format of the dma specifier depends on the dma
- controller.
+- tx-dma-channel: The dma channel specifier for tx operations. The format of
- the dma specifier depends on the dma controller.
+- rx-dma-channel: The dma channel specifier for rx operations. The format of
- the dma specifier depends on the dma controller.
+Optional SoC Specific Properties:
+- samsung,supports-6ch: If the I2S Primary sound source has 5.1 Channel
- support, this flag is enabled.
+- samsung,supports-rstclr: This flag should be set if I2S software reset bit
- control is required. When this flag is set I2S software reset bit will be
- enabled or disabled based on need.
+- samsung,supports-secdai:If I2S block has a secondary FIFO and internal DMA,
- then this flag is enabled.
+- samsung,idma-addr: Internal DMA register base address of the audio
- sub system(used in secondary sound source).
+Required Board Specific Properties:
+- gpios: The gpio specifier for data out,data in, LRCLK, CDCLK and SCLK
- interface lines. The format of the gpio specifier depends on the gpio
- controller.
- The syntax of samsung gpio specifier is
- <[phandle of the gpio controller node]
[pin number within the gpio controller][mux function][flags and pull up/down][drive strength]>+Aliases:
+- All the I2S controller nodes are represented in the aliases node using
- the following format 'i2s{n}' where n is a unique number for the alias.
Are the aliases actually being used now? If not, then drop this section. I don't see any references in this patch.
Otherwise the binding looks good to me.
g.
On Wed, Dec 19, 2012 at 01:24:14PM +0000, Grant Likely wrote:
On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna padma.v@samsung.com wrote:
+- compatible : "samsung,samsung-i2s"
Isn't that kind of redundant? :-)
The format of the compatible strings should be "<vendor>,<part-number>-i2s". Please be specific about the part number that you're doing the binding for. For example; use "samsung,exynos4210-i2s" instead of "samsung,exynos-i2s".
There are actually versioned IPs here (where the versions are used publically in a few places) but it's not clearly documented which is which. It would be reasonable to use the IP versions here I think.
Hi,
On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Wed, Dec 19, 2012 at 01:24:14PM +0000, Grant Likely wrote:
On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna padma.v@samsung.com wrote:
+- compatible : "samsung,samsung-i2s"
Isn't that kind of redundant? :-)
The format of the compatible strings should be "<vendor>,<part-number>-i2s". Please be specific about the part number that you're doing the binding for. For example; use "samsung,exynos4210-i2s" instead of "samsung,exynos-i2s".
There are actually versioned IPs here (where the versions are used publically in a few places) but it's not clearly documented which is which. It would be reasonable to use the IP versions here I think.
Samsung has three i2s drivers one for s3c24xx, one for s3c2412 and one for rest of the platforms. The above mentioned other platforms has Version 3/4/5 of i2s controllers. This dt binding is for for the i2s driver that has support for Version 3/4/5 of i2s controller. So "samsung,i2s-v5" is okay as compatible name? Please suggest me.
Thanks Padma
Kukjin Kim wrote:
Re-sending due to e-mail client problem :(
Padma Venkat wrote:
Hi,
On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Wed, Dec 19, 2012 at 01:24:14PM +0000, Grant Likely wrote:
On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna
padma.v@samsung.com wrote:
+- compatible : "samsung,samsung-i2s"
Isn't that kind of redundant? :-)
The format of the compatible strings should be "<vendor>,<part-
number>-i2s".
Please be specific about the part number that you're doing the binding for. For example; use "samsung,exynos4210-i2s" instead of
"samsung,exynos-i2s".
There are actually versioned IPs here (where the versions are used publically in a few places) but it's not clearly documented which is which. It would be reasonable to use the IP versions here I think.
Samsung has three i2s drivers one for s3c24xx, one for s3c2412 and one for rest of the platforms. The above mentioned other platforms has Version 3/4/5 of i2s controllers. This dt binding is for for the i2s
Where is the version defined such as 3, 4, 5? So, what is the "sound/soc/Samsung/s3c-i2s-v2.[ch]"?
driver that has support for Version 3/4/5 of i2s controller. So "samsung,i2s-v5" is okay as compatible name? Please suggest me.
I agree with using version here but we need some consensus about that.
- Kukjin
participants (4)
-
Grant Likely -
Kukjin Kim -
Mark Brown -
Padma Venkat