At Tue, 12 Oct 2010 12:36:45 +0200, David Henningsson wrote:

This one never got picked up when I posted it a week ago.

Oh yeah, thanks for noticing. Applied now.

Takashi

On 2010-10-04 12:15, David Henningsson wrote:

...

Position_fix quirks for specific machines now override the default position_fix behavior for all HDA controllers.

BugLink: http://launchpad.net/bugs/465942 BugLink: http://launchpad.net/bugs/580749 BugLink: http://launchpad.net/bugs/587546

Signed-off-by: David Henningsson david.henningsson@canonical.com

---

Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

-- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic [2 0001-ALSA-HDA-Correctly-apply-position_fix-quirks-for-ATI.patch <text/x-patch (7bit)>]

...

From b36e71f568c26ab11909454c5bf8bc5d47dbf025 Mon Sep 17 00:00:00 2001

From: David Henningsson david.henningsson@canonical.com Date: Mon, 4 Oct 2010 12:02:14 +0200 Subject: [PATCH] ALSA: HDA: Correctly apply position_fix quirks for ATI and VIA controllers

Position_fix quirks for specific machines now override the default position_fix behavior for all HDA controllers.

BugLink: http://launchpad.net/bugs/465942 BugLink: http://launchpad.net/bugs/580749 BugLink: http://launchpad.net/bugs/587546

Signed-off-by: David Henningsson david.henningsson@canonical.com

sound/pci/hda/hda_intel.c | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 38b063e..5cbea85 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2315,14 +2315,6 @@ static int __devinit check_position_fix(struct azx *chip, int fix) return fix; }

• /* Check VIA/ATI HD Audio Controller exist */
• switch (chip->driver_type) {
• case AZX_DRIVER_VIA:
• case AZX_DRIVER_ATI:

• /* Use link position directly, avoid any transfer problem. */
  

• return POS_FIX_VIACOMBO;
  

• }
• q = snd_pci_quirk_lookup(chip->pci, position_fix_list); if (q) { printk(KERN_INFO

@@ -2331,6 +2323,15 @@ static int __devinit check_position_fix(struct azx *chip, int fix) q->value, q->subvendor, q->subdevice); return q->value; }

• /* Check VIA/ATI HD Audio Controller exist */
• switch (chip->driver_type) {
• case AZX_DRIVER_VIA:
• case AZX_DRIVER_ATI:

• /* Use link position directly, avoid any transfer problem. */
  

• return POS_FIX_VIACOMBO;
  

• }
• return POS_FIX_AUTO;

}

-- 1.7.1