[alsa-devel] [PATCH] CS4270: comments: slave mode is now supported
Just a minor thing: make the comments reflect the new slave mode feature.
Signed-off-by: Daniel Mack daniel@caiaq.de Cc: Timur Tabi timur@freescale.com --- sound/soc/codecs/cs4270.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 4c7e546..0558674 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -14,12 +14,11 @@ * * 1) Software mode is supported. Stand-alone mode is not supported. * 2) Only I2C is supported, not SPI - * 3) Only Master mode is supported, not Slave. - * 4) The machine driver's 'startup' function must call + * 3) The machine driver's 'startup' function must call * cs4270_set_dai_sysclk() with the value of MCLK. - * 5) Only I2S and left-justified modes are supported - * 6) Power management is not supported - * 7) The only supported control is volume and hardware mute (if enabled) + * 4) Only I2S and left-justified modes are supported + * 5) Power management is not supported + * 6) The only supported control is volume and hardware mute (if enabled) */
#include <linux/module.h>
On Sun, Mar 8, 2009 at 11:16 AM, Daniel Mack daniel@caiaq.de wrote:
- Only Master mode is supported, not Slave.
- The machine driver's 'startup' function must call
- The machine driver's 'startup' function must call
I would have been simpler if you just said that both Master and Slave mode is supported. However, if you really want to delete #3, you may as well get rid of all the numbers, so that we don't have to renumber them again in the future.
- The only supported control is volume and hardware mute (if enabled)
This is no longer true. Pretty much all controls are now supported. I should have changed that in my prior patch, but for now could you just delete #6? Thanks.
Hi Timur,
On Sun, Mar 08, 2009 at 11:40:30AM -0500, Timur Tabi wrote:
On Sun, Mar 8, 2009 at 11:16 AM, Daniel Mack daniel@caiaq.de wrote:
- Only Master mode is supported, not Slave.
- The machine driver's 'startup' function must call
- The machine driver's 'startup' function must call
I would have been simpler if you just said that both Master and Slave mode is supported.
Right, I mistakenly read the whole list as limitations, but the headline says 'features' as well.
However, if you really want to delete #3, you may as well get rid of all the numbers, so that we don't have to renumber them again in the future.
Ok, that makes sense. What about the patch below?
Daniel
On Sun, Mar 8, 2009 at 11:51 AM, Daniel Mack daniel@caiaq.de wrote:
Ok, that makes sense. What about the patch below?
Looks great. I appreciate the work you're doing to improve the driver. What product will you be using this in?
From 5bf6359108726950c48f9f709eabc2c7e3a09eba Mon Sep 17 00:00:00 2001 From: Daniel Mack daniel@caiaq.de Date: Sun, 8 Mar 2009 17:48:12 +0100 Subject: [PATCH] CS4270: bring feature/limitations list in sync
Removes numbers from the list of features/limitations and makes it reflect recent changes to the code.
Signed-off-by: Daniel Mack daniel@caiaq.de
Acked-by: Timur Tabi timur@freescale.com
On Sun, Mar 08, 2009 at 12:25:43PM -0500, Timur Tabi wrote:
Ok, that makes sense. What about the patch below?
Looks great. I appreciate the work you're doing to improve the driver. What product will you be using this in?
This will be used in a series of multi-room home audio devices. I'll let you know when there is something the marketing department releases ;)
Removes numbers from the list of features/limitations and makes it reflect recent changes to the code.
Signed-off-by: Daniel Mack daniel@caiaq.de
Acked-by: Timur Tabi timur@freescale.com
Thanks!
Daniel
participants (2)
-
Daniel Mack -
Timur Tabi