Re: [alsa-devel] [PATCH v2] duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE
At Tue, 19 Aug 2008 11:53:54 -0400, roel kluin wrote:
Takashi Iwai wrote:
At Tue, 19 Aug 2008 08:15:05 +0200 (CEST), Johannes Berg wrote:
roel kluin wrote:
untested, is it correct?
not a clue, do you know how long ago that was? :) does the driver check endianness anywhere?
AFAIK snd-aoa supports only bit-endian formats (at least in sound/aoa/soundbus/i2sbus-pcm.c), so this addition makes little sense.
Better to drop the duplicated words there.
Thanks Johannes and Takashi,
FWIW this removes the duplicates.
Remove duplicate assignment of SNDRV_PCM_FMTBIT_S{16,24}_BE bits
Signed-off-by: Roel Kluin roel.kluin@gmail.com
Thanks, applied this one now.
Takashi
diff --git a/sound/aoa/codecs/snd-aoa-codec-tas.c b/sound/aoa/codecs/snd-aoa-codec-tas.c index 7a16a33..6c515b2 100644 --- a/sound/aoa/codecs/snd-aoa-codec-tas.c +++ b/sound/aoa/codecs/snd-aoa-codec-tas.c @@ -654,15 +654,13 @@ static struct snd_kcontrol_new bass_control = { static struct transfer_info tas_transfers[] = { { /* input */
.formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S16_BE |SNDRV_PCM_FMTBIT_S24_BE | SNDRV_PCM_FMTBIT_S24_BE,
.formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S24_BE,
.formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S16_BE |SNDRV_PCM_FMTBIT_S24_BE | SNDRV_PCM_FMTBIT_S24_BE,
.formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S24_BE,
participants (1)
-
Takashi Iwai