At Fri, 21 Nov 2008 03:50:32 +0100, Diego E. 'Flameeyes' Pettenò wrote:

I've taken some time to fix some autotools nitpicks and some generic optimisations, I hope they can be useful:

git://git.flameeyes.eu/others/alsa/alsa-lib.git flameeyes

Diego E. 'Flameeyes' Pettenò (5): Don't use AC_CANONICAL_SYSTEM, only use AC_CANONICAL_HOST. Add the attributes.m4 macro file from xine/lscube. Check for --no-undefined linker flag and use it. Make sure that python libraries are passed through LIBADD. Make some static tables and strings constants.

These changes look OK, but could you add your sign-off to each commit?

git://git.flameeyes.eu/others/alsa/alsa-plugins.git flameeyes

Diego E. 'Flameeyes' Pettenò (6): Add the attributes.m4 macro file from xine/lscube. Check for --no-undefined linker flag and use it. Cleanup flags in maemo/Makefile.am [RFC] Don't use pow() for calculating a power of 2, use shift instead. Make some static tables and strings constants. Mark as static the functions not used outside their unit.

Ditto.

git://git.flameeyes.eu/others/alsa/alsa-utils.git flameeyes

Diego E. 'Flameeyes' Pettenò (4): Remove some dead code (comparisons between 0 and unsigned integers).

The change in alsactl/state.c gives wrong indentations. Please fix.

  Remove some unused variables.
  Mark static the functions not used outside their unit.
  Make some static tables and strings constants.

Give your sign-off, please, too.

thanks,

Takashi