[alsa-devel] BT87x ALSA driver patches
On Mon, 23 Jul 2007, Mauro Carvalho Chehab wrote:
Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:
01/01: bttv: Fix Viewcast Osprey 440 support http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3
I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?
Please send to ALSA guys, c/c me.
Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.
Do you plan to send this to git as one patch, or to strip out the ALSA change? I'm just wondering if I should send these two lines to the ALSA people as a separate patch, of if they will get them into their hg via a kernel-sync patch. My bt87x patches depend on this one, so somehow the ALSA hg needs to get this change before I can send them the next two.
The problem really, is that having two divers for the same chip split into v4l-dvb and ALSA like this a pain. IMHO, it would make a lot more sense to put the bttv alsa driver into v4l-dvb, like the saa7134 alsa and oss and cx88 alsa drivers are.
drivers/media/video/bt8xx/bttv-cards.c | 240 ++++++++++++++++++--------------- sound/pci/bt87x.c | 2 2 files changed, 137 insertions(+), 105 deletions(-)
At Wed, 25 Jul 2007 15:43:50 -0700 (PDT), Trent Piepho wrote:
On Mon, 23 Jul 2007, Mauro Carvalho Chehab wrote:
Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:
01/01: bttv: Fix Viewcast Osprey 440 support http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3
I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?
Please send to ALSA guys, c/c me.
Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.
In such a case, I think one patch makes more sense.
Mauro, please apply it from your tree all together?
Do you plan to send this to git as one patch, or to strip out the ALSA change? I'm just wondering if I should send these two lines to the ALSA people as a separate patch, of if they will get them into their hg via a kernel-sync patch. My bt87x patches depend on this one, so somehow the ALSA hg needs to get this change before I can send them the next two.
The problem really, is that having two divers for the same chip split into v4l-dvb and ALSA like this a pain. IMHO, it would make a lot more sense to put the bttv alsa driver into v4l-dvb, like the saa7134 alsa and oss and cx88 alsa drivers are.
OTOH, fixing cx88 and saa7134 codes are also painful for us :)
thanks,
Takashi
Em Qui, 2007-07-26 às 12:01 +0200, Takashi Iwai escreveu:
At Wed, 25 Jul 2007 15:43:50 -0700 (PDT), Trent Piepho wrote:
On Mon, 23 Jul 2007, Mauro Carvalho Chehab wrote:
Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:
01/01: bttv: Fix Viewcast Osprey 440 support http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3
I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?
Please send to ALSA guys, c/c me.
Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.
In such a case, I think one patch makes more sense.
Mauro, please apply it from your tree all together?
Ok. The changeset with the newer PCI IDs, together with the V4L changes, is available on my tree at:
http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commit;h=99f...
Do you wanna me also to take care of the changesets improving bt87x to properly work with Osprey 440, or do you prefer if Trent sent you directly, c/c me?
OTOH, fixing cx88 and saa7134 codes are also painful for us :)
There's no easy solution for those "merged" work...
At Fri, 27 Jul 2007 12:11:15 -0300, Mauro Carvalho Chehab wrote:
Em Qui, 2007-07-26 às 12:01 +0200, Takashi Iwai escreveu:
At Wed, 25 Jul 2007 15:43:50 -0700 (PDT), Trent Piepho wrote:
On Mon, 23 Jul 2007, Mauro Carvalho Chehab wrote:
Em Sáb, 2007-07-21 às 17:36 -0700, Trent Piepho escreveu:
01/01: bttv: Fix Viewcast Osprey 440 support http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=8e72fe5675b3
I have two other changes that only affect the ALSA driver part. Should I send those to ALSA or to you?
Please send to ALSA guys, c/c me.
Ok, I'll do that. What about the two lines to bt87x.c that this patch added? I seemed logical to me that they should be part of the same patch at git as the changes to bttv-cards.c, but I suppose it's not 100% necessary to do so, the kernel will still compile and not crash.
In such a case, I think one patch makes more sense.
Mauro, please apply it from your tree all together?
Ok. The changeset with the newer PCI IDs, together with the V4L changes, is available on my tree at:
http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commit;h=99f...
Thanks!
Do you wanna me also to take care of the changesets improving bt87x to properly work with Osprey 440, or do you prefer if Trent sent you directly, c/c me?
I don't mind you apply and push it from your tree at all, but patches are always welcome, even only for checking.
Takashi
Do you wanna me also to take care of the changesets improving bt87x to properly work with Osprey 440, or do you prefer if Trent sent you directly, c/c me?
I don't mind you apply and push it from your tree at all, but patches are always welcome, even only for checking.
For me, both ways should work fine. Of course, it is important to have your eyes looking at those changesets.
participants (3)
-
Mauro Carvalho Chehab -
Takashi Iwai -
Trent Piepho