Re: [alsa-devel] [PATCH 1/3] ASoC: Add gtm601 codec driver
Just a nit: a license mismatch.
On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote:
--- /dev/null +++ b/sound/soc/codecs/gtm601.c
- This program is free software; you can redistribute it and/or modify it
- under the terms of the GNU General Public License as published by the
- Free Software Foundation; either version 2 of the License, or (at your
- option) any later version.
This states the license is GPL v2 or later.
+MODULE_LICENSE("GPL v2");
And, according to include/linux/module.h, this states the license is (just) GPL v2. So I think either the comment at the top of this file or the ident used in the MODULE_LICESE() macro should change.
Paul Bolle
Hi Paul,
On Fri, May 1, 2015 at 9:30 AM, Paul Bolle pebolle@tiscali.nl wrote:
Just a nit: a license mismatch.
Right, I copy and paste license header from wm827 driver but add MODULE_LICENSE wrong version. I'll update in next version. Thanks.
On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote:
--- /dev/null +++ b/sound/soc/codecs/gtm601.c
- This program is free software; you can redistribute it and/or modify it
- under the terms of the GNU General Public License as published by the
- Free Software Foundation; either version 2 of the License, or (at your
- option) any later version.
This states the license is GPL v2 or later.
+MODULE_LICENSE("GPL v2");
And, according to include/linux/module.h, this states the license is (just) GPL v2. So I think either the comment at the top of this file or the ident used in the MODULE_LICESE() macro should change.
Paul Bolle
BR,
marek
participants (2)
-
Belisko Marek -
Paul Bolle