[alsa-devel] [PATCH] ASoC: Fix reg_cache_size for stac9766
reg_cache_size is supposed to be the number of elements in the register cache, not the size in bytes.
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/codecs/stac9766.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/stac9766.c b/sound/soc/codecs/stac9766.c index 5581953..da71615 100644 --- a/sound/soc/codecs/stac9766.c +++ b/sound/soc/codecs/stac9766.c @@ -380,7 +380,7 @@ static struct snd_soc_codec_driver soc_codec_dev_stac9766 = { .remove = stac9766_codec_remove, .suspend = stac9766_codec_suspend, .resume = stac9766_codec_resume, - .reg_cache_size = sizeof(stac9766_reg), + .reg_cache_size = ARRAY_SIZE(stac9766_reg), .reg_word_size = sizeof(u16), .reg_cache_step = 2, .reg_cache_default = stac9766_reg,
On Mon, Dec 05, 2011 at 10:06:04AM +0800, Axel Lin wrote:
reg_cache_size is supposed to be the number of elements in the register cache, not the size in bytes.
Applied, though note that in this case as the register values are 8 bits the two numbers are exactly the same so this is a coding style fix only (but still useful!).
2011/12/5 Mark Brown broonie@opensource.wolfsonmicro.com:
On Mon, Dec 05, 2011 at 10:06:04AM +0800, Axel Lin wrote:
reg_cache_size is supposed to be the number of elements in the register cache, not the size in bytes.
Applied, though note that in this case as the register values are 8 bits the two numbers are exactly the same so this is a coding style fix only (but still useful!).
Actually, the register values are 16 bits. static const u16 stac9766_reg[] = {
Axel
participants (2)
-
Axel Lin
-
Mark Brown