[alsa-devel] [PATCH 0/2] Fixed issues/defects reported by Coverity tool.
From: Sudarshan sudarshan.bisht@nokia.com
Coverity Static Analysis helps developers find hard-to-spot, yet potentially crash-causing defects early in the development phase, reducing the cost,time, and risk of software errors.
* First patch here is just a cosmetic one as it removes tabs and trailing whitespaces from the code.
* Second patch has got fixes for some minor issues/defects reported by Coverity tool and these fixes can prevent memory leaks and crashes in some cases. It also has some whitespaces and tabs removal differences, please ignore them.
Sudarshan (1): alsa-lib: Removed trailing whitespaces as per pulseaudio coding guidelines.
bisht (1): alsa-lib: Coverity tool has picked some minor issues in alsa-lib source code, fixed them.
aserver/aserver.c | 1813 +++++++------- modules/mixer/simple/sbase.c | 837 ++++---- modules/mixer/simple/sbasedl.c | 126 +- src/alisp/alisp.c | 4 +- src/alisp/alisp_snd.c | 1493 ++++++------ src/conf.c | 5117 ++++++++++++++++++++-------------------- src/control/control_hw.c | 597 +++--- src/control/control_shm.c | 1019 ++++---- src/control/setup.c | 3 +- src/hwdep/hwdep.c | 496 ++-- src/mixer/mixer.c | 962 ++++---- src/mixer/simple_abst.c | 1 + src/mixer/simple_none.c | 15 +- src/pcm/pcm.c | 4812 +++++++++++++++++++------------------- src/pcm/pcm_file.c | 1452 ++++++------ src/pcm/pcm_hooks.c | 937 ++++---- src/pcm/pcm_ladspa.c | 2284 +++++++++--------- src/pcm/pcm_local.h | 3 +- src/pcm/pcm_meter.c | 1634 +++++++------- src/pcm/pcm_rate.c | 2166 +++++++++--------- src/pcm/pcm_share.c | 10 +- src/pcm/pcm_shm.c | 1329 ++++++------ src/pcm/pcm_simple.c | 404 ++-- src/rawmidi/rawmidi.c | 2 +- src/rawmidi/rawmidi_virt.c | 8 +- 25 files changed, 13782 insertions(+), 13742 deletions(-)
sudarshan.bisht@nokia.com wrote:
Sudarshan (1): alsa-lib: Removed trailing whitespaces as per pulseaudio coding guidelines.
bisht (1): alsa-lib: Coverity tool has picked some minor issues in alsa-lib source code, fixed them.
Apparently, your patches were too big and got stuck in some spam filter.
Try to compress them, or put them somewhere on the web.
Regards, Clemens
Thanks for notifying this,
I will compress them and send once again.
Best Regards, Sudarshan Bisht
On Mon, 2010-12-06 at 13:51 +0100, ext Clemens Ladisch wrote:
sudarshan.bisht@nokia.com wrote:
Sudarshan (1): alsa-lib: Removed trailing whitespaces as per pulseaudio coding guidelines.
bisht (1): alsa-lib: Coverity tool has picked some minor issues in alsa-lib source code, fixed them.
Apparently, your patches were too big and got stuck in some spam filter.
Try to compress them, or put them somewhere on the web.
Regards, Clemens _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Please find attached zipped patches.
On Mon, 2010-12-06 at 13:51 +0100, ext Clemens Ladisch wrote:
sudarshan.bisht@nokia.com wrote:
Sudarshan (1): alsa-lib: Removed trailing whitespaces as per pulseaudio coding guidelines.
bisht (1): alsa-lib: Coverity tool has picked some minor issues in alsa-lib source code, fixed them.
Apparently, your patches were too big and got stuck in some spam filter.
Try to compress them, or put them somewhere on the web.
Regards, Clemens _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Sudarshan Bisht wrote:
- First patch here is just a cosmetic one as it removes
tabs and trailing whitespaces from the code.
The ALSA code uses kernel style, not PulseAudio; please don't remove tabs.
- Second patch has got fixes for some minor issues/defects
reported by Coverity tool and these fixes can prevent memory leaks and crashes in some cases. It also has some whitespaces and tabs removal differences, please ignore them.
The whitespace stuff makes it hard to review the patches. Please run diff with the -w parameter to ignore that.
Regards, Clemens
participants (3)
-
Clemens Ladisch
-
Sudarshan Bisht
-
sudarshan.bisht@nokia.com