[alsa-devel] [PATCH] ALSA: hda - Optimize resume for codecs without jack detection
The codecs without jack detection also don't have to be resumed forcibly because, obviously, they have no jack. Skip the forced resume in such a case as optimization as well.
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/pci/hda/hda_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index e30e86ca6b72..51f10ed9bc43 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -2942,7 +2942,7 @@ static int hda_codec_runtime_resume(struct device *dev) static int hda_codec_force_resume(struct device *dev) { struct hda_codec *codec = dev_to_hda_codec(dev); - bool forced_resume = !codec->relaxed_resume; + bool forced_resume = !codec->relaxed_resume && codec->jacktbl.used; int ret;
/* The get/put pair below enforces the runtime resume even if the
Hi,
On Wed, 17 Jul 2019, Takashi Iwai wrote:
The codecs without jack detection also don't have to be resumed forcibly because, obviously, they have no jack. Skip the forced resume in such a case as optimization as well.
looks good. I did a light test round for this, together with the previous "ALSA: hda - Don't resume forcibly i915 HDMI/DP codec" and seem good.
Reviewed-by: Kai Vehmanen kai.vehmanen@linux.intel.com
participants (2)
-
Kai Vehmanen
-
Takashi Iwai