[PATCH] mfd: cs42l43: add REGMAP_IRQ requirement
The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ to what the core driver selects in order to provide this API. This fixes a build error:
aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work': cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") Signed-off-by: Randy Dunlap rdunlap@infradead.org Cc: Charles Keepax ckeepax@opensource.cirrus.com Cc: James Schulman james.schulman@cirrus.com Cc: David Rhodes david.rhodes@cirrus.com Cc: Richard Fitzgerald rf@opensource.cirrus.com Cc: alsa-devel@alsa-project.org Cc: patches@opensource.cirrus.com Cc: Lee Jones lee@kernel.org --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff -- a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -241,6 +241,7 @@ config MFD_CS42L43 tristate select MFD_CORE select REGMAP + select REGMAP_IRQ
config MFD_CS42L43_I2C tristate "Cirrus Logic CS42L43 (I2C)"
On Mon, Sep 18, 2023 at 12:30:42PM -0700, Randy Dunlap wrote:
The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ to what the core driver selects in order to provide this API. This fixes a build error:
aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work': cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") Signed-off-by: Randy Dunlap rdunlap@infradead.org Cc: Charles Keepax ckeepax@opensource.cirrus.com Cc: James Schulman james.schulman@cirrus.com Cc: David Rhodes david.rhodes@cirrus.com Cc: Richard Fitzgerald rf@opensource.cirrus.com Cc: alsa-devel@alsa-project.org Cc: patches@opensource.cirrus.com Cc: Lee Jones lee@kernel.org
Someone already sent a fix for this, that is awaiting review:
https://lore.kernel.org/lkml/tencent_E54C7156F583E15FFE320E576E3389C39A08@qq...
But just incase this one gets picked up:
Acked-by: Charles Keepax ckeepax@opensource.cirrus.com
Thanks, Charles
participants (2)
-
Charles Keepax
-
Randy Dunlap