[alsa-devel] [PATCH] ASoC: omap: N810: Don't select CONFIG_OMAP_MUX but make it as dependency
Not all omap boards use kernel based pin multiplexing so CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make harm to other boards in multi-board kernels.
Therefore put CONFIG_OMAP_MUX as a dependency to N810 ASoC machine driver.
Thanks to Tony Lindgren tony@atomide.com for noticing.
Signed-off-by: Jarkko Nikula jhnikula@gmail.com Cc: Tony Lindgren tony@atomide.com --- sound/soc/omap/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index d542ea2..a088db6 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -12,8 +12,8 @@ config SND_OMAP_SOC_MCPDM config SND_OMAP_SOC_N810 tristate "SoC Audio support for Nokia N810" depends on SND_OMAP_SOC && MACH_NOKIA_N810 && I2C + depends on OMAP_MUX select SND_OMAP_SOC_MCBSP - select OMAP_MUX select SND_SOC_TLV320AIC3X help Say Y if you want to add support for SoC audio on Nokia N810.
On Wed, Dec 01, 2010 at 11:01:20AM +0200, Jarkko Nikula wrote:
Not all omap boards use kernel based pin multiplexing so CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make harm to other boards in multi-board kernels.
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
* Mark Brown broonie@opensource.wolfsonmicro.com [101201 03:19]:
On Wed, Dec 01, 2010 at 11:01:20AM +0200, Jarkko Nikula wrote:
Not all omap boards use kernel based pin multiplexing so CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make harm to other boards in multi-board kernels.
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
Jarkko thanks for fixing this:
Acked-by: Tony Lindgren tony@atomide.com
On Wed, 2010-12-01 at 11:01 +0200, Jarkko Nikula wrote:
Not all omap boards use kernel based pin multiplexing so CONFIG_SND_OMAP_SOC_N810 should not select it by default as it can make harm to other boards in multi-board kernels.
Therefore put CONFIG_OMAP_MUX as a dependency to N810 ASoC machine driver.
Thanks to Tony Lindgren tony@atomide.com for noticing.
Signed-off-by: Jarkko Nikula jhnikula@gmail.com Cc: Tony Lindgren tony@atomide.com
Applied.
Thanks
Liam
participants (4)
-
Jarkko Nikula
-
Liam Girdwood
-
Mark Brown
-
Tony Lindgren