Hi,

On 4/6/20 5:17 PM, Pierre-Louis Bossart wrote:

...

...

So overall it seems rather unlikely that we can support dmic + headset mic in parallel?

Right that is what the ConflictingDevices sections are for.

Removing the JackHWMute does not allow using both add the same time, it merely allows overriding which of the 2 to use (if the headset mic is detected by the jack, the JackControl setting is kept).

So lets say the internal mic is crappy, but the user prefers to have their ears free, then they can use a headset around there neck, using just the headset-mic and select speakers as output even though a jack is inserted.

Note pulseaudio will still automatically switch to the headphones / headsetmic when plugged in, this merely allows overriding that choice manually.

Jacks which actually physically disable (or re-route) signals are quite rare now a days so having a JackHWMute in the UCM conf is often wrong. After this patch only a few cases are left:

[hans@x1 alsa-ucm-conf]$ ack -l JackHWMute ucm2 ucm2/HDA-Intel/HiFi-dual.conf ucm2/chtrt5650/HiFi.conf ucm2/hda-dsp/HiFi.conf ucm2/codecs/es8316/HeadPhones.conf ucm2/sof-bdw-rt5677/HiFi.conf ucm2/broxton-rt298/HiFi.conf ucm2/skylake-rt286/HiFi.conf

The es8316 case is actually correct, the es8316 has only 1 output (which is amplified for e.g. a speaker) and at least the reference design suggests routing the speaker signal through the jack and using a jack which will interrupt the signal when headphones are plugged in.

Note most actual designs implement this with an analog switch and a GPIO to control that switch, since 3.5 mm jacks which actually can disconnect a signal are rare (if they exist at all, but I guess they do). For the designs using the GPIO controlled analog switch, the JackHWMute technically also is wrong, but I put it there (IIRC it was me) because it matches the reference design.

I'm not familiar enough with any of the others to say anything about them, but most of them are for HDA setups, where this is somewhat more normal I guess.

If I follow the logic, I guess we should also remove the JackHWMute for sof-bdw-rt5677, hda-dsp and HDA-Intel. I can't think of a hardware limitation preventing the headset mic from being used while the speakers are used for playback. Likewise the rt5650 is a cheaper version of rt5645 so the same applies.

Right AFAIK:

JackHWMute "foo"

Means that the JackControl listed in the same section does something at the hardware level which makes it impossible for the "foo" input / output to function until the jack is removed. Typically this would be something like actually disconnecting the speakers at the electrical level.

So almost always using it is wrong.

Regards,

Hans

...

...

If I follow the logic, I guess we should also remove the JackHWMute for sof-bdw-rt5677, hda-dsp and HDA-Intel. I can't think of a hardware limitation preventing the headset mic from being used while the speakers are used for playback. Likewise the rt5650 is a cheaper version of rt5645 so the same applies.

Right AFAIK:

JackHWMute "foo"

Means that the JackControl listed in the same section does something at the hardware level which makes it impossible for the "foo" input / output to function until the jack is removed. Typically this would be something like actually disconnecting the speakers at the electrical level.

So almost always using it is wrong.

I agree. The description is really straight (use-case.h):

"Note that JackHWMute should be used only when the hardware enforces the automatic muting."

Pierre, it seems that hds-dsp uses JackHWMute for Speaker and Headphones, I think that it should be removed. Otherwise PA thinks that those devices cannot be used simultaneously when user wants to..

Right, that hda-dsp UCM config probably needs more work between the JackHWMute and only supporting 2 HDMI paths, but that's not maintained by me or anyone on the SOF team. Adding Mateusz Gorski in Cc:

please also remove es8316 HeadPhones.conf JackHWMute "Speaker"

Yes, you are right. remove the EnableSeq.conf stupid Disable all output, i can get speaker and headphone work on ubuntu focal with pulseaudio. if remove JackHWMute "Speaker", speaker and headphone both has sound.

2020-04-13 22:39 GMT+08:00, Hans de Goede hdegoede@redhat.com:

Hi,

On 4/13/20 3:19 PM, youling257 wrote:

...

please also remove es8316 HeadPhones.conf JackHWMute "Speaker"

Erm, no that is not right. The ES8316 actually needs this.

The es8316 actually only has 1 amplified output (and no un-amplified outputs IIRC). In the reference designs (appnote) for the es8316 the output is actually switched in hardware based on jack-detect.

In practice this is implemented by connecting the L/R speaker output signals *directly* to the jack and through a analog switch which is controlled through a GPIO to the speakers.

So when headphones are plugged in we can (and must) disable the analog-switch so that the speakers are disconnected from the outputs and the outputs only drive the headphones.

If we remove the JackHWMute "Speaker" and then switch the sound to the speakers, the sound will be send to both the speakers and the headphones at the same time; there is no way to turn off the headphones.

So we need the JackHWMute "Speaker" here.

Regards,

Hans

Dne 05. 04. 20 v 20:34 Hans de Goede napsal(a):

Fix HiFi-stereo-dmic2 conf not loading because of references to non existing devices in the ConflictingDevices sections.

Stop playing Rename + Remove tricks with the output (Speaker2) and input (DMIC1) devices which we do not want to be part of this config, this does not work now that we only allow devices which are actually part of our config in the ConflictingDevices sections.

The Remove and Rename operations should also manage (remove and rename) devices in ConflictingDevices/SupportedDevices sections. What's the exact error you hit?

If I simulate this via ucm-validator I get this device structure:

Verb: "HiFi" File: HiFi-stereo-dmic2.conf Device: "Headphones" ConflictingDevices.0 = Speaker Value.PlaybackPriority = 300 Value.PlaybackPCM = 'hw:${CardId}' Value.JackControl = 'Headphone Jack' Device: "Headset" ConflictingDevices.0 = Mic Value.CapturePriority = 300 Value.CapturePCM = 'hw:${CardId}' Value.JackControl = 'Headset Mic Jack' Device: "Speaker" ConflictingDevices.0 = Headphones Value.PlaybackPriority = 200 Value.PlaybackPCM = 'hw:${CardId}' Device: "Mic" ConflictingDevices.0 = Headset Value.CapturePriority = 200 Value.CapturePCM = 'hw:${CardId}'

It appears like an issue in alsa-lib.

Jaroslav

Dne 06. 04. 20 v 11:50 Hans de Goede napsal(a):

Hi,

On 4/6/20 11:34 AM, Jaroslav Kysela wrote:

...

Dne 05. 04. 20 v 20:34 Hans de Goede napsal(a):

...

Fix HiFi-stereo-dmic2 conf not loading because of references to non existing devices in the ConflictingDevices sections.

Stop playing Rename + Remove tricks with the output (Speaker2) and input (DMIC1) devices which we do not want to be part of this config, this does not work now that we only allow devices which are actually part of our config in the ConflictingDevices sections.

The Remove and Rename operations should also manage (remove and rename) devices in ConflictingDevices/SupportedDevices sections. What's the exact error you hit?

If I simulate this via ucm-validator I get this device structure:

Verb: "HiFi"     File: HiFi-stereo-dmic2.conf     Device: "Headphones"       ConflictingDevices.0 = Speaker       Value.PlaybackPriority = 300       Value.PlaybackPCM = 'hw:${CardId}'       Value.JackControl = 'Headphone Jack'     Device: "Headset"       ConflictingDevices.0 = Mic       Value.CapturePriority = 300       Value.CapturePCM = 'hw:${CardId}'       Value.JackControl = 'Headset Mic Jack'     Device: "Speaker"       ConflictingDevices.0 = Headphones       Value.PlaybackPriority = 200       Value.PlaybackPCM = 'hw:${CardId}'     Device: "Mic"       ConflictingDevices.0 = Headset       Value.CapturePriority = 200       Value.CapturePCM = 'hw:${CardId}'

It appears like an issue in alsa-lib.

With an unmodified UCM2 profile I get the following:

[hans@localhost ~]$ alsaucm -c cht-bsw-rt5672 set _verb HiFi set _enadev Speaker ALSA lib parser.c:1138:(verb_dev_list_add) error: unable to find device 'Speaker2' ALSA lib parser.c:1433:(parse_verb_file) error: device management error in verb 'HiFi' ALSA lib main.c:962:(snd_use_case_mgr_open) error: failed to import cht-bsw-rt5672 use case configuration -2 alsaucm: error failed to open sound card cht-bsw-rt5672: No such file or directory

Note the _enadev does not matter, things break before it gets parsed, if I replace Speaker with XXX I get the exact same errors.

I'm happy to try any alsa-lib patches on this (Thinkpad8) hw for you.

I think that I found the culprit. Could you test this, please?

https://github.com/alsa-project/alsa-lib/commit/c9605484d165d2b707f78eef14a2...

Thank you, Jaroslav

Dne 06. 04. 20 v 14:13 Hans de Goede napsal(a):

Hi,

On 4/6/20 1:28 PM, Jaroslav Kysela wrote:

...

Dne 06. 04. 20 v 11:50 Hans de Goede napsal(a):

...

Hi,

On 4/6/20 11:34 AM, Jaroslav Kysela wrote:

...

Dne 05. 04. 20 v 20:34 Hans de Goede napsal(a):

...

Fix HiFi-stereo-dmic2 conf not loading because of references to non existing devices in the ConflictingDevices sections.

Stop playing Rename + Remove tricks with the output (Speaker2) and input (DMIC1) devices which we do not want to be part of this config, this does not work now that we only allow devices which are actually part of our config in the ConflictingDevices sections.

The Remove and Rename operations should also manage (remove and rename) devices in ConflictingDevices/SupportedDevices sections. What's the exact error you hit?

If I simulate this via ucm-validator I get this device structure:

 Verb: "HiFi"
    File: HiFi-stereo-dmic2.conf
    Device: "Headphones"
      ConflictingDevices.0 = Speaker
      Value.PlaybackPriority = 300
      Value.PlaybackPCM = 'hw:${CardId}'
      Value.JackControl = 'Headphone Jack'
    Device: "Headset"
      ConflictingDevices.0 = Mic
      Value.CapturePriority = 300
      Value.CapturePCM = 'hw:${CardId}'
      Value.JackControl = 'Headset Mic Jack'
    Device: "Speaker"
      ConflictingDevices.0 = Headphones
      Value.PlaybackPriority = 200
      Value.PlaybackPCM = 'hw:${CardId}'
    Device: "Mic"
      ConflictingDevices.0 = Headset
      Value.CapturePriority = 200
      Value.CapturePCM = 'hw:${CardId}'

It appears like an issue in alsa-lib.

With an unmodified UCM2 profile I get the following:

[hans@localhost ~]$ alsaucm -c cht-bsw-rt5672 set _verb HiFi set _enadev Speaker ALSA lib parser.c:1138:(verb_dev_list_add) error: unable to find device 'Speaker2' ALSA lib parser.c:1433:(parse_verb_file) error: device management error in verb 'HiFi' ALSA lib main.c:962:(snd_use_case_mgr_open) error: failed to import cht-bsw-rt5672 use case configuration -2 alsaucm: error failed to open sound card cht-bsw-rt5672: No such file or directory

Note the _enadev does not matter, things break before it gets parsed, if I replace Speaker with XXX I get the exact same errors.

I'm happy to try any alsa-lib patches on this (Thinkpad8) hw for you.

I think that I found the culprit. Could you test this, please?

https://github.com/alsa-project/alsa-lib/commit/c9605484d165d2b707f78eef14a2...

I added that patch to the alsa-lib-1.2.2 package, did a build and installed it, unfortunately it does not help:

[hans@localhost ~]$ rpm -q alsa-lib alsa-lib-1.2.2-1.hdg1.fc33.x86_64 [hans@localhost ~]$ alsaucm -c cht-bsw-rt5672 set _verb HiFi set _enadev Speaker ALSA lib parser.c:1138:(verb_dev_list_add) error: unable to find device 'Speaker2' ...

Another one line fix:

https://github.com/alsa-project/alsa-lib/commit/fb48ad9e4f6b84fd4ade689bd79e...

Jaroslav

Regards,

Hans

Hi,

On 4/6/20 12:02 PM, Hans de Goede wrote:

Hi,

On 4/6/20 11:34 AM, Jaroslav Kysela wrote:

...

Dne 05. 04. 20 v 20:34 Hans de Goede napsal(a):

...

Fix HiFi-stereo-dmic2 conf not loading because of references to non existing devices in the ConflictingDevices sections.

Stop playing Rename + Remove tricks with the output (Speaker2) and input (DMIC1) devices which we do not want to be part of this config, this does not work now that we only allow devices which are actually part of our config in the ConflictingDevices sections.

The Remove and Rename operations should also manage (remove and rename) devices in ConflictingDevices/SupportedDevices sections. What's the exact error you hit?

If I simulate this via ucm-validator I get this device structure:

Verb: "HiFi"      File: HiFi-stereo-dmic2.conf      Device: "Headphones"        ConflictingDevices.0 = Speaker        Value.PlaybackPriority = 300        Value.PlaybackPCM = 'hw:${CardId}'        Value.JackControl = 'Headphone Jack'      Device: "Headset"        ConflictingDevices.0 = Mic        Value.CapturePriority = 300        Value.CapturePCM = 'hw:${CardId}'        Value.JackControl = 'Headset Mic Jack'      Device: "Speaker"        ConflictingDevices.0 = Headphones        Value.PlaybackPriority = 200        Value.PlaybackPCM = 'hw:${CardId}'      Device: "Mic"        ConflictingDevices.0 = Headset        Value.CapturePriority = 200        Value.CapturePCM = 'hw:${CardId}'

It appears like an issue in alsa-lib.

Ok so I found the following weird:

RemoveDevice."Speaker2" "Speaker2"

At a hunch I removed the extra "Speaker2", now I get:

[hans@localhost ~]$ alsaucm -c cht-bsw-rt5672 set _verb HiFi set _enadev Speaker ALSA lib parser.c:1138:(verb_dev_list_add) error: unable to find device 'Mic1' ...

Notice the error changed from being about Speaker2 to Mic1, so this looks good, but then I did the same with the:

RemoveDevice."Mic1" "Mic1"

Line, dropping the extra "Mic1" I get:

[hans@localhost ~]$ alsaucm -c cht-bsw-rt5672 set _verb HiFi set _enadev Speaker ALSA lib parser.c:1183:(verb_device_management) error: cannot remove device 'Mic' ...

Which is weird...

Even weirder I was thinking that the Rename + Remove lines should be after the last include, so that they also get applied to the Conflicting devices of e.g . the Headphones Section Device, but if I move the Rename + Remove lines for the Mic to the end of the HiFi-stereo-dmic2.conf file I get:

[hans@localhost ~]$ alsaucm -c cht-bsw-rt5672 set _verb HiFi set _enadev Speaker ALSA lib conf.c:1928:(_snd_config_load_with_include) _toplevel_:23:0:Unexpected end of file ALSA lib utils.c:285:(uc_mgr_config_load) could not load configuration file /usr/share/alsa/ucm2/cht-bsw-rt5672/HiFi-stereo-dmic2.conf ALSA lib parser.c:1349:(parse_verb_file) error: failed to open verb file /usr/share/alsa/ucm2/cht-bsw-rt5672/HiFi-stereo-dmic2.conf : 0 ALSA lib main.c:962:(snd_use_case_mgr_open) error: failed to import cht-bsw-rt5672 use case configuration -22 alsaucm: error failed to open sound card cht-bsw-rt5672: Invalid argument

Last mail, sorry about the spam.

Ok, this is caused by me removing the extra "Mic1" at the end of the RemoveDevice line.

Things still do not work with the in my mind more logical order of having these at the end though.

Regards,

Hans