Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
On Thu, Jan 3, 2019 at 5:08 AM Chandan Rajendra chandan@linux.ibm.com wrote:
On Thursday, January 3, 2019 5:20:27 AM IST Pierre-Louis Bossart wrote:
On 1/2/19 4:58 PM, Sinan Kaya wrote:
On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:
This is pointing to a kconfig issue on ia64 arch.
arch/ia64/Kconfig:128:error: recursive dependency detected! arch/ia64/Kconfig:128: choice <choice> contains symbol IA64_HP_SIM arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM
IA64_HP_SIM is both a choice and is selected.
I did allyesconfig and disabled PCI afterwards to find all the issues on this patchset.
Are you saying there's a newer series that fixes this issue for both allyesconfig and allmodconfig?
if yes, then we're good.
No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I used allyesconfig to find out all compilation issues on x86 arch to come up with this patchset.
Nothing makes me cringe more than "somebody else's job" statements. In this case, there is obviously a correlation with your ACPI changes since the circular dependency happens because of the ACPI symbol.
arch/ia64/Kconfig:126:error: recursive dependency detected! arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by HIBERNATION kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP init/Kconfig:250: symbol SWAP depends on BLOCK block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI <<<< LOOK HERE drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by IA64_HP_SIM arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
At any rate, a 3 mn git bisect tells me the circular dependency is exposed by this change:
f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit commit f3fd6cd74fedf99b6060f75df00943fda13b65f2 Author: Chandan Rajendra chandan@linux.vnet.ibm.com Date: Sat Dec 8 12:21:38 2018 +0530
fscrypt: remove filesystem specific build config option In order to have a common code base for fscrypt "post read" processing for all filesystems which support encryption, this commit removes filesystem specific build config option (e.g.CONFIG_EXT4_FS_ENCRYPTION) and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose value affects all the filesystems making use of fscrypt.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
OK
Pierre-Louis, can you check if this patch makes the issue go away for you, please?
arch/ia64/Kconfig:126:error: recursive dependency detected! arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by HIBERNATION kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP init/Kconfig:250: symbol SWAP depends on BLOCK block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI <<<< LOOK HERE drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by IA64_HP_SIM arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
At any rate, a 3 mn git bisect tells me the circular dependency is exposed by this change:
f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit commit f3fd6cd74fedf99b6060f75df00943fda13b65f2 Author: Chandan Rajendra chandan@linux.vnet.ibm.com Date: Sat Dec 8 12:21:38 2018 +0530
fscrypt: remove filesystem specific build config option In order to have a common code base for fscrypt "post read" processing for all filesystems which support encryption, this commit removes filesystem specific build config option (e.g.CONFIG_EXT4_FS_ENCRYPTION) and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose value affects all the filesystems making use of fscrypt.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
OK
Pierre-Louis, can you check if this patch makes the issue go away for you, please?
Wondering if Chandan provided the right pointer, I wasn't able to apply this patch, but commenting out "select BLOCK if FS_ENCRYPTION" in fs/ubifs/Kconfig makes the circular dependency go away. All good for me.
On Thursday, January 3, 2019 9:58:28 PM IST Pierre-Louis Bossart wrote:
arch/ia64/Kconfig:126:error: recursive dependency detected! arch/ia64/Kconfig:126: choice <choice> contains symbol IA64_HP_SIM arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by HIBERNATION kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP init/Kconfig:250: symbol SWAP depends on BLOCK block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI <<<< LOOK HERE drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by IA64_HP_SIM arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice <choice>
At any rate, a 3 mn git bisect tells me the circular dependency is exposed by this change:
f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit commit f3fd6cd74fedf99b6060f75df00943fda13b65f2 Author: Chandan Rajendra chandan@linux.vnet.ibm.com Date: Sat Dec 8 12:21:38 2018 +0530
fscrypt: remove filesystem specific build config option In order to have a common code base for fscrypt "post read" processing for all filesystems which support encryption, this commit removes filesystem specific build config option (e.g.CONFIG_EXT4_FS_ENCRYPTION) and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose value affects all the filesystems making use of fscrypt.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>FWIW, The patch at https://patchwork.kernel.org/patch/10725883/ fixes this problem by removing "select BLOCK if FS_ENCRYPTION" from fs/ubifs/Kconfig.
OK
Pierre-Louis, can you check if this patch makes the issue go away for you, please?
Wondering if Chandan provided the right pointer, I wasn't able to apply this patch, but commenting out "select BLOCK if FS_ENCRYPTION" in fs/ubifs/Kconfig makes the circular dependency go away. All good for me.
V4 version of the patchset (which is part of linux-next) had introduced the "select BLOCK if FS_ENCRYPTION". The V5 patchset omits that line. Hence the patch did not apply cleanly. However just commenting out that line was the right thing to do.
participants (3)
-
Chandan Rajendra -
Pierre-Louis Bossart -
Rafael J. Wysocki