[alsa-devel] [PATCH] - ALSA hda ad1988 - Add Independent HP Switch to model 6stack-dig-fp
Add Independent HP Switch to model 6stack-dig-fp
allow user to switch Independent HP on/off by using ALSA specific "share stream" mode
This don't need to make "Headphone Playback Volume" inactive but this also mean that "Headphone Playback Volume" is no longer slave of the "Virtual Master" any more
The alternative way is to use the audio selector 0x37 but there is 1) no simple mixer api for alsamixer to display an inactive "Headphone Playback Volume" and active "Headphone Playback Switch" 2) no api to add/remove "Headphone Playback Volume" to/from the slave list of "Virtual Master"
snd_hda_codec_write(codec, 0x37, 0, AC_VERB_SET_CONNECT_SEL, spec->independent_hp ? 0x00 : 0x01 );
At Tue, 19 Apr 2011 08:12:57 +0800, Raymond Yau wrote:
Add Independent HP Switch to model 6stack-dig-fp
allow user to switch Independent HP on/off by using ALSA specific "share stream" mode
This don't need to make "Headphone Playback Volume" inactive but this also mean that "Headphone Playback Volume" is no longer slave of the "Virtual Master" any more
The implementation looks almost OK (although there are a few pieces of unused code slike activate_ctl()), I prefer an enum control for it.
It's a frequently seen problem that user sets "Independent HP" mixer switch accidentally and gets unexpected results. An enum control tends to be more clear than a mixer switch in general.
Could you rewrite the patch (and do a bit more clean up) and resend?
thanks,
Takashi
participants (2)
-
Raymond Yau -
Takashi Iwai