On 1/13/2021 5:48 AM, Kai-Heng Feng wrote:

On Tue, Jan 12, 2021 at 9:25 PM Amadeusz Sławiński amadeuszx.slawinski@linux.intel.com wrote:

...

On 12/17/2020 9:25 AM, Kai-Heng Feng wrote: (...)

...

...

...

Can you try this instead, the dependencies are indeed wrong in the Makefile:

Ok, compiling a kernel for user to test...

Well, this happens: ERROR: modpost: "skl_dsp_set_dma_control" [sound/soc/intel/skylake/snd-soc-skl-ssp-clk.ko] undefined! make[1]: *** [scripts/Makefile.modpost:111: sound/Module.symvers] Error 1 make[1]: *** Deleting file 'sound/Module.symvers' make: *** [Makefile:1709: modules] Error 2

Kai-Heng

...

Kai-Heng

...

diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile index 4e0248d2accc..7c5038803be7 100644 --- a/sound/soc/intel/Makefile +++ b/sound/soc/intel/Makefile @@ -5,7 +5,7 @@ obj-$(CONFIG_SND_SOC) += common/ # Platform Support obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += atom/ obj-$(CONFIG_SND_SOC_INTEL_CATPT) += catpt/ -obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/ +obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += skylake/ obj-$(CONFIG_SND_SOC_INTEL_KEEMBAY) += keembay/

# Machine support

Hi,

what is the status of this issue?

Still the same, unresolved.

...

Does it now work with usptream kernel?

No it doesn't.

Can you try with following patch:

diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile index 4e0248d2accc..7c5038803be7 100644 --- a/sound/soc/intel/Makefile +++ b/sound/soc/intel/Makefile @@ -5,7 +5,7 @@ obj-$(CONFIG_SND_SOC) += common/ # Platform Support obj-$(CONFIG_SND_SST_ATOM_HIFI2_PLATFORM) += atom/ obj-$(CONFIG_SND_SOC_INTEL_CATPT) += catpt/ -obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += skylake/ +obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += skylake/ obj-$(CONFIG_SND_SOC_INTEL_KEEMBAY) += keembay/

# Machine support diff --git a/sound/soc/intel/skylake/Makefile b/sound/soc/intel/skylake/Makefile index dd39149b89b1..1c4649bccec5 100644 --- a/sound/soc/intel/skylake/Makefile +++ b/sound/soc/intel/skylake/Makefile @@ -7,7 +7,7 @@ ifdef CONFIG_DEBUG_FS snd-soc-skl-objs += skl-debug.o endif

-obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += snd-soc-skl.o +obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON) += snd-soc-skl.o

#Skylake Clock device support snd-soc-skl-ssp-clk-objs := skl-ssp-clk.o