On 10/13/19 11:47 PM, Stephen Rothwell wrote:

Hi all,

Changes since 20191011:

on i386:

ld: sound/soc/sof/control.o: in function `snd_sof_switch_put': control.c:(.text+0x49a): undefined reference to `ledtrig_audio_set' ld: control.c:(.text+0x4d1): undefined reference to `ledtrig_audio_set'

when CONFIG_LEDS_TRIGGER_AUDIO=m CONFIG_SND_SOC_SOF=y

This code in <linux/leds.h> does not handle the config combo above:

#if IS_ENABLED(CONFIG_LEDS_TRIGGER_AUDIO) enum led_brightness ledtrig_audio_get(enum led_audio type); void ledtrig_audio_set(enum led_audio type, enum led_brightness state); #else static inline enum led_brightness ledtrig_audio_get(enum led_audio type) { return LED_OFF; } static inline void ledtrig_audio_set(enum led_audio type, enum led_brightness state) { } #endif