[alsa-devel] [PATCH] ASoC: ab8500: Explicitly set I/O up
From: Mark Brown broonie@linaro.org
We do some I/O in probe so we need to ensure the I/O operations are fully set up then.
Reported-by: Olof Johansson olof@lixom.net Signed-off-by: Mark Brown broonie@linaro.org --- sound/soc/codecs/ab8500-codec.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c index ca500fd..a0394a8 100644 --- a/sound/soc/codecs/ab8500-codec.c +++ b/sound/soc/codecs/ab8500-codec.c @@ -2473,6 +2473,8 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec)
dev_dbg(dev, "%s: Enter.\n", __func__);
+ snd_soc_codec_set_cache_io(codec, 0, 0, SND_SOC_REGMAP); + /* Setup AB8500 according to board-settings */ pdata = dev_get_platdata(dev->parent);
On Tue, 24 Sep 2013, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
We do some I/O in probe so we need to ensure the I/O operations are fully set up then.
Reported-by: Olof Johansson olof@lixom.net Signed-off-by: Mark Brown broonie@linaro.org
sound/soc/codecs/ab8500-codec.c | 2 ++ 1 file changed, 2 insertions(+)
Olof, would you mind testing this please?
On Tue, Sep 24, 2013 at 01:01:15PM +0100, Lee Jones wrote:
On Tue, 24 Sep 2013, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
We do some I/O in probe so we need to ensure the I/O operations are fully set up then.
Olof, would you mind testing this please?
It's in -next so should be caught by the build tomorrow if you don't mind waiting.
From: Mark Brown broonie@linaro.org
We do some I/O in probe so we need to ensure the I/O operations are fully set up then.
Olof, would you mind testing this please?
It's in -next so should be caught by the build tomorrow if you don't mind waiting.
I'm in no rush. OOI, did the build pick up the first issue reported by Olof?
On Tue, Sep 24, 2013 at 7:19 AM, Mark Brown broonie@kernel.org wrote:
On Tue, Sep 24, 2013 at 01:01:15PM +0100, Lee Jones wrote:
On Tue, 24 Sep 2013, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
We do some I/O in probe so we need to ensure the I/O operations are fully set up then.
Olof, would you mind testing this please?
It's in -next so should be caught by the build tomorrow if you don't mind waiting.
Looks like the overnight -next run passed without problems on snowball, thanks for the quick fix.
-Olof
On Wed, 25 Sep 2013, Olof Johansson wrote:
On Tue, Sep 24, 2013 at 7:19 AM, Mark Brown broonie@kernel.org wrote:
On Tue, Sep 24, 2013 at 01:01:15PM +0100, Lee Jones wrote:
On Tue, 24 Sep 2013, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
We do some I/O in probe so we need to ensure the I/O operations are fully set up then.
Olof, would you mind testing this please?
It's in -next so should be caught by the build tomorrow if you don't mind waiting.
Looks like the overnight -next run passed without problems on snowball, thanks for the quick fix.
Nice. Thanks for Reporting/Testing Olof.
participants (3)
-
Lee Jones -
Mark Brown -
Olof Johansson