[PATCH] ASoC: soc-compress: avoid false-positive Wuninitialized warning
gcc-6.5 and earlier show a new warning:
sound/soc/soc-compress.c: In function ‘soc_compr_open’: sound/soc/soc-compress.c:75:28: warning: ‘component’ is used uninitialized in this function [-Wuninitialized] struct snd_soc_component *component, *save = NULL; ^~~~~~~~~
Simplest fix is to initialize it to avoid the warning.
Reported-by: kbuild test robot lkp@intel.com Cc: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Link: https://lore.kernel.org/lkml/202004201540.vYPhhYMs%25lkp@intel.com Signed-off-by: Rong Chen rong.a.chen@intel.com --- sound/soc/soc-compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index 50062eb79adb..e7bd80ed7f2e 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -72,7 +72,7 @@ static int soc_compr_components_free(struct snd_compr_stream *cstream, static int soc_compr_open(struct snd_compr_stream *cstream) { struct snd_soc_pcm_runtime *rtd = cstream->private_data; - struct snd_soc_component *component, *save = NULL; + struct snd_soc_component *component = NULL, *save = NULL; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; int ret, i;
Hi
gcc-6.5 and earlier show a new warning:
sound/soc/soc-compress.c: In function ‘soc_compr_open’: sound/soc/soc-compress.c:75:28: warning: ‘component’ is used uninitialized in this function [-Wuninitialized] struct snd_soc_component *component, *save = NULL; ^~~~~~~~~
Simplest fix is to initialize it to avoid the warning.
Reported-by: kbuild test robot lkp@intel.com Cc: Kuninori Morimoto kuninori.morimoto.gx@renesas.com Link: https://lore.kernel.org/lkml/202004201540.vYPhhYMs%25lkp@intel.com Signed-off-by: Rong Chen rong.a.chen@intel.com
Acked-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Thank you for your help !!
Best regards --- Kuninori Morimoto
On Wed, Apr 22, 2020 at 03:35:43PM +0800, Rong Chen wrote:
gcc-6.5 and earlier show a new warning:
sound/soc/soc-compress.c: In function ‘soc_compr_open’: sound/soc/soc-compress.c:75:28: warning: ‘component’ is used uninitialized in this function [-Wuninitialized] struct snd_soc_component *component, *save = NULL; ^~~~~~~~~
Simplest fix is to initialize it to avoid the warning.
This doesn't apply against current code, please check and resend. TBH I'm not 100% sure the benefit here is worth it, this is a very old compiler and it seems like a bug in the compiler.
On Wed, 22 Apr 2020 15:35:43 +0800, Rong Chen wrote:
gcc-6.5 and earlier show a new warning:
sound/soc/soc-compress.c: In function ‘soc_compr_open’: sound/soc/soc-compress.c:75:28: warning: ‘component’ is used uninitialized in this function [-Wuninitialized] struct snd_soc_component *component, *save = NULL; ^~~~~~~~~
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8
Thanks!
[1/1] ASoC: soc-compress: avoid false-positive Wuninitialized warning commit: 3e645a4add53eec22f3818c9da01c19191525096
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Kuninori Morimoto -
Mark Brown -
Rong Chen