[alsa-devel] Function ap192_4wire_start in revo.c
Hello, while working on support for AK4114 in Audiotrak MI/ODI/O, I have come accross a bug in revo.c (used for major inspiration :) )The function
static unsigned char ap192_4wire_start(struct snd_ice1712 *ice)
returns value of current GPIO bits, which is unsigned int. However, return value of the function is unsigned char. This results in clearing all GPIO8-22 in next snd_ice1712_gpio_write call of the 4-wire protocol communication which is a little bit inconvenient :).
Thanks for fixing in HG.
Best regards,
Pavel.
At Thu, 29 Mar 2007 11:14:50 +0200 (CEST), dustin@seznam.cz wrote:
Hello, while working on support for AK4114 in Audiotrak MI/ODI/O, I have come accross a bug in revo.c (used for major inspiration :) )The function
static unsigned char ap192_4wire_start(struct snd_ice1712 *ice)
returns value of current GPIO bits, which is unsigned int. However, return value of the function is unsigned char. This results in clearing all GPIO8-22 in next snd_ice1712_gpio_write call of the 4-wire protocol communication which is a little bit inconvenient :).
Indeed. Fixed on HG now. Thanks for spotting out.
Takashi
participants (2)
-
dustin＠seznam.cz -
Takashi Iwai