Re: [alsa-devel] [PATCH] pxa2xx-lib: support building for several pxa's
Hi, 2008/7/30 Russ Dill <russ.dill@gmail.com>:
Here's a version of the third patch in the series without all the #ifdef's. Just a quick question for Dmitry, why all the if (! cpu_is_pxa3xx())'s around the pxa_gpio_mode's? Also, there was a build error when just building the sound/arm pxa2xx-ac97.
Good! AFAIR pxa_gpio_mode isn't valid for the the pxa3xx, so cpu_is_pxa3xx().
Support building pxa2xx-lib for several pxa chip versions by making code run-time selected, not only compile-time
Signed-off-by: Russ Dill <russ.dill@gmail.com> --- include/asm-arm/arch-pxa/pxa-regs.h | 4 +- sound/arm/Kconfig | 2 +- sound/arm/pxa2xx-ac97-lib.c | 174 ++++++++++++++++------------------ sound/soc/pxa/pxa2xx-i2s.c | 16 ++- 4 files changed, 95 insertions(+), 101 deletions(-)
-- With best wishes Dmitry
On Thu, Jul 31, 2008 at 02:41:21AM +0400, Dmitry wrote:
#ifdef's. Just a quick question for Dmitry, why all the if (! cpu_is_pxa3xx())'s around the pxa_gpio_mode's? Also, there was a build error when just building the sound/arm pxa2xx-ac97.
AFAIR pxa_gpio_mode isn't valid for the the pxa3xx, so cpu_is_pxa3xx().
Not really. The thing is that historically drivers set the MFP mappings up themselves rather than letting the board code do it. Going forward that should be being done by the platform code but simply removing the configuration for PXA2xx would break existing users. Aside from that the PXA3xx series provide multiple MFP options for the AC97 interface so we can't do an unconditional setup for them anyway - the configuration is always board specific.
participants (2)
-
Dmitry -
Mark Brown