[alsa-devel] [PATCH] ASoC: qcom: Return an error for invalid PCM trigger command
Fix a compile warning sound/soc/qcom/lpass-cpu.c: In function ‘lpass_cpu_daiops_trigger’: sound/soc/qcom/lpass-cpu.c:224:2: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] return ret; ^ Although switch () lists the most of existing cases, it's still better to cover the rest as an error properly.
Signed-off-by: Takashi Iwai tiwai@suse.de --- sound/soc/qcom/lpass-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index 6698d058de29..dc790abaa331 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -194,7 +194,7 @@ static int lpass_cpu_daiops_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai) { struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai); - int ret; + int ret = -EINVAL;
switch (cmd) { case SNDRV_PCM_TRIGGER_START:
On Mon, Apr 13, 2015 at 02:23:29PM +0200, Takashi Iwai wrote:
Fix a compile warning sound/soc/qcom/lpass-cpu.c: In function ???lpass_cpu_daiops_trigger???: sound/soc/qcom/lpass-cpu.c:224:2: warning: ???ret??? may be used uninitialized in this function [-Wmaybe-uninitialized] return ret; ^ Although switch () lists the most of existing cases, it's still better to cover the rest as an error properly.
Signed-off-by: Takashi Iwai tiwai@suse.de
sound/soc/qcom/lpass-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Kenneth Westfield kwestfie@codeaurora.org
participants (3)
-
Kenneth Westfield -
Mark Brown -
Takashi Iwai