[PATCH AUTOSEL 5.7 130/388] ASoC: Fix wrong dependency of da7210 and wm8983
From: Wei Li liwei391@huawei.com
[ Upstream commit c1c050ee74d67aeb879fd38e3a07139d7fdb79f4 ]
As these two drivers support I2C and SPI, we should add the SND_SOC_I2C_AND_SPI dependency instead.
Fixes: ce0c97f8a2936 ("ASoC: Fix SND_SOC_ALL_CODECS imply SPI fallout") Signed-off-by: Wei Li liwei391@huawei.com Link: https://lore.kernel.org/r/20200420202410.47327-3-liwei391@huawei.com Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org --- sound/soc/codecs/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 8cdc68c141dc..7d2cbed55a9d 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -717,7 +717,7 @@ config SND_SOC_L3
config SND_SOC_DA7210 tristate - depends on I2C + depends on SND_SOC_I2C_AND_SPI
config SND_SOC_DA7213 tristate "Dialog DA7213 CODEC" @@ -1569,7 +1569,7 @@ config SND_SOC_WM8978
config SND_SOC_WM8983 tristate - depends on I2C + depends on SND_SOC_I2C_AND_SPI
config SND_SOC_WM8985 tristate "Wolfson Microelectronics WM8985 and WM8758 codec driver"
On Wed, Jun 17, 2020 at 09:03:47PM -0400, Sasha Levin wrote:
From: Wei Li liwei391@huawei.com
[ Upstream commit c1c050ee74d67aeb879fd38e3a07139d7fdb79f4 ]
As these two drivers support I2C and SPI, we should add the SND_SOC_I2C_AND_SPI dependency instead.
This is purely about build testing, are you sure this is stable material?
On Thu, Jun 18, 2020 at 12:02:58PM +0100, Mark Brown wrote:
On Wed, Jun 17, 2020 at 09:03:47PM -0400, Sasha Levin wrote:
From: Wei Li liwei391@huawei.com
[ Upstream commit c1c050ee74d67aeb879fd38e3a07139d7fdb79f4 ]
As these two drivers support I2C and SPI, we should add the SND_SOC_I2C_AND_SPI dependency instead.
This is purely about build testing, are you sure this is stable material?
Is this not something that can happen in practice?
On Sun, Jun 21, 2020 at 07:34:53PM -0400, Sasha Levin wrote:
On Thu, Jun 18, 2020 at 12:02:58PM +0100, Mark Brown wrote:
This is purely about build testing, are you sure this is stable material?
Is this not something that can happen in practice?
Not outside of build testing.
On Mon, Jun 22, 2020 at 11:18:30AM +0100, Mark Brown wrote:
On Sun, Jun 21, 2020 at 07:34:53PM -0400, Sasha Levin wrote:
On Thu, Jun 18, 2020 at 12:02:58PM +0100, Mark Brown wrote:
This is purely about build testing, are you sure this is stable material?
Is this not something that can happen in practice?
Not outside of build testing.
Okay, I'll drop it.
participants (2)
-
Mark Brown -
Sasha Levin