Re: [PATCH 4/4] ASoC: wm8904: add DMIC support
Hi All,
+static const char *cin_text[] = { + "ADC", "DMIC" +};
+static SOC_ENUM_SINGLE_DECL(cin_enum, + WM8904_DIGITAL_MICROPHONE_0, 12, cin_text);
Why would this be runtime selectable? I'd expect the decision to use an analogue or digital microphone to be made in the hardware design.
I agree that dedicated HW is required, but currently SW side there's no support at all. This patch is aiming to provide a way to enable DMIC on boards using it. Is this supposed to be managed in a different way ?
Thanks Best Regards Pier
On Mon, Jun 20, 2022 at 02:49:51PM +0000, Pierluigi Passaro wrote:
+static const char *cin_text[] = { + "ADC", "DMIC" +};
+static SOC_ENUM_SINGLE_DECL(cin_enum, + WM8904_DIGITAL_MICROPHONE_0, 12, cin_text);
Why would this be runtime selectable? I'd expect the decision to use an analogue or digital microphone to be made in the hardware design.
I agree that dedicated HW is required, but currently SW side there's no support at all. This patch is aiming to provide a way to enable DMIC on boards using it. Is this supposed to be managed in a different way ?
Via firmware description.
participants (2)
-
Mark Brown -
Pierluigi Passaro