Re: [PATCH] drm/bridge: dw-hdmi-i2s: set insert_pcuv bit if hardware supports it
22 Aug
2022
22 Aug
'22
4:35 p.m.
On Mon, Aug 22, 2022 at 02:27:26PM +0100, Mark Brown wrote:
On Sat, Aug 20, 2022 at 09:36:53PM -0300, Geraldo Nascimento wrote:
- /*
* dw-hdmi introduced insert_pcuv bit in version 2.10a.
* When set (1'b1), this bit enables the insertion of the PCUV
* (Parity, Channel Status, User bit and Validity) bits on the
* incoming audio stream (support limited to Linear PCM audio)
*/
- if (hdmi_read(audio, HDMI_DESIGN_ID) >= 0x21)
conf2 |= HDMI_AUD_CONF2_INSERT_PCUV;
So what if we're not handlign linear PCM?
Good question, Mark. For HBR and NL-PCM there are different bits that need to be set in aud_conf2 Sample Register, and then insert_pcuv bit needs to be dropped.
I don't have a sink handy however to test the other modes. Do you have a suggestion on how to make this the default for L-PCM specifically?
Thanks, Geraldo Nascimento
853
Age (days ago)
853
Last active (days ago)
0 comments
1 participants
participants (1)
-
Geraldo Nascimento