[alsa-devel] [PATCH 32/33] ASoC: max98095: use match_string() helper
match_string() returns the index of an array for a matching string, which can be used intead of open coded variant.
Cc: Liam Girdwood lgirdwood@gmail.com Cc: Mark Brown broonie@kernel.org Cc: Jaroslav Kysela perex@perex.cz Cc: Takashi Iwai tiwai@suse.com Cc: alsa-devel@alsa-project.org Signed-off-by: Yisheng Xie xieyisheng1@huawei.com --- sound/soc/codecs/max98095.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c index 6bf2d0b..0ef42dc 100644 --- a/sound/soc/codecs/max98095.c +++ b/sound/soc/codecs/max98095.c @@ -1634,15 +1634,12 @@ static void max98095_handle_eq_pdata(struct snd_soc_component *component) static int max98095_get_bq_channel(struct snd_soc_component *component, const char *name) { - int i; - - for (i = 0; i < ARRAY_SIZE(bq_mode_name); i++) - if (strcmp(name, bq_mode_name[i]) == 0) - return i; + int ret = match_string(bq_mode_name, ARRAY_SIZE(bq_mode_name), name);
/* Shouldn't happen */ - dev_err(component->dev, "Bad biquad channel name '%s'\n", name); - return -EINVAL; + if (ret < 0) + dev_err(component->dev, "Bad biquad channel name '%s'\n", name); + return ret; }
static int max98095_put_bq_enum(struct snd_kcontrol *kcontrol,
On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie xieyisheng1@huawei.com wrote:
match_string() returns the index of an array for a matching string, which can be used intead of open coded variant.
int ret = match_string(bq_mode_name, ARRAY_SIZE(bq_mode_name), name);
Rather split and move an assignment to the line before 'if'.
/* Shouldn't happen */
if (ret < 0)
dev_err(component->dev, "Bad biquad channel name '%s'\n", name);
return ret;
}
participants (2)
-
Andy Shevchenko
-
Yisheng Xie