[alsa-devel] [PATCH] hda: Distortion fix for dell_m6_core_init
Added the EQ distortion fix to the dell_m6_core_init.
--- Signed-off-by: Matthew Ranostay mranostay@embeddedalley.com
diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index 6ad6ef3..9968ee4 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c @@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = { };
static struct hda_verb dell_m6_core_init[] = { - /* set master volume and direct control */ - { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff}, + /* set master volume to max value without distortion + * and direct control */ + { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec}, /* setup audio connections */ { 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00}, { 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
At Sun, 31 Aug 2008 14:53:38 -0400, Matthew Ranostay wrote:
Added the EQ distortion fix to the dell_m6_core_init.
Signed-off-by: Matthew Ranostay mranostay@embeddedalley.com
Thanks. I'll include this as 2.6.27 fixes, too.
BTW, I found the volume-knob on 0x1f is set to 0xff with other models (e.g. intel boards). Don't you need to fix them as well?
Takashi
diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index 6ad6ef3..9968ee4 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c @@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = { };
static struct hda_verb dell_m6_core_init[] = {
- /* set master volume and direct control */
- { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
- /* set master volume to max value without distortion
* and direct control */- { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec}, /* setup audio connections */ { 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00}, { 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
Takashi Iwai wrote:
At Sun, 31 Aug 2008 14:53:38 -0400, Matthew Ranostay wrote:
Added the EQ distortion fix to the dell_m6_core_init.
Signed-off-by: Matthew Ranostay mranostay@embeddedalley.com
Thanks. I'll include this as 2.6.27 fixes, too.
BTW, I found the volume-knob on 0x1f is set to 0xff with other models (e.g. intel boards). Don't you need to fix them as well?
Nope, they don't have this issue.
Takashi
diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c index 6ad6ef3..9968ee4 100644 --- a/pci/hda/patch_sigmatel.c +++ b/pci/hda/patch_sigmatel.c @@ -606,8 +606,9 @@ static struct hda_verb dell_eq_core_init[] = { };
static struct hda_verb dell_m6_core_init[] = {
- /* set master volume and direct control */
- { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
- /* set master volume to max value without distortion
* and direct control */- { 0x1f, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xec}, /* setup audio connections */ { 0x0d, AC_VERB_SET_CONNECT_SEL, 0x00}, { 0x0a, AC_VERB_SET_CONNECT_SEL, 0x01},
participants (2)
-
Matthew Ranostay -
Takashi Iwai