[alsa-devel] [PATCH] ASoC: sta32x: fix register range in regmap.
The STA32X_AUTO3 is a writable register that currently does not appear in the regmap ranges(neither read nor write). By adding this register to the register ranges there is no gap anymore and the existing register ranges can be joined. This fixes a regression that made it impossible to choose the preset EQ mode set through the STA32X_AUTO3 register.
Signed-off-by: Thomas Niederprüm niederp@physik.uni-kl.de --- I realized that I missed one register in the DT enabling patchset, so here I send a patch to clean up my mess :)
Thomas
sound/soc/codecs/sta32x.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index bc6edb1..d320227 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -107,13 +107,11 @@ static const struct reg_default sta32x_regs[] = { };
static const struct regmap_range sta32x_write_regs_range[] = { - regmap_reg_range(STA32X_CONFA, STA32X_AUTO2), - regmap_reg_range(STA32X_C1CFG, STA32X_FDRC2), + regmap_reg_range(STA32X_CONFA, STA32X_FDRC2), };
static const struct regmap_range sta32x_read_regs_range[] = { - regmap_reg_range(STA32X_CONFA, STA32X_AUTO2), - regmap_reg_range(STA32X_C1CFG, STA32X_STATUS), + regmap_reg_range(STA32X_CONFA, STA32X_STATUS), };
static const struct regmap_range sta32x_volatile_regs_range[] = {
On Sun, Feb 15, 2015 at 04:53:36PM +0100, Thomas Niederprüm wrote:
The STA32X_AUTO3 is a writable register that currently does not appear in the regmap ranges(neither read nor write). By adding this register to the register ranges there is no gap anymore and the existing register ranges can be joined. This fixes a regression that made it impossible to choose the preset EQ mode set through the STA32X_AUTO3 register.
This doesn't seem to apply to current code, can you please check and resend? It would also be good to say why the regression that's being fixed happens.
participants (2)
-
Mark Brown
-
Thomas Niederprüm