[alsa-devel] [PATCH] ASoC: simple-card: Cleanup __asoc_simple_card_dai_init() ret check
The ret parameter is always equal to zero till here.
Signed-off-by: Xiubo Li Li.Xiubo@freescale.com --- sound/soc/generic/simple-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 643c9ed..6ce9745 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -25,7 +25,7 @@ static int __asoc_simple_card_dai_init(struct snd_soc_dai *dai,
daifmt |= set->fmt;
- if (!ret && daifmt) + if (daifmt) ret = snd_soc_dai_set_fmt(dai, daifmt);
if (ret == -ENOTSUPP) {
On Mon, Dec 23, 2013 at 01:24:59PM +0800, Xiubo Li wrote:
The ret parameter is always equal to zero till here.
Applied, thanks. This is on the edge of what's a good cleanup - it's a taste thing if it's better to have every call be the same so the code looks more regular or if it's better to have the redundant test removed.
participants (2)
-
Mark Brown -
Xiubo Li