[PATCH] ALSA: isa: Fix inconsistent indenting
Kernel test robot throws below warning ->
smatch warnings: sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn: inconsistent indenting sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn: inconsistent indenting
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com --- sound/isa/opti9xx/opti92x-ad1848.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c index 08e61d9..234f023 100644 --- a/sound/isa/opti9xx/opti92x-ad1848.c +++ b/sound/isa/opti9xx/opti92x-ad1848.c @@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip, chip->mc_base_size = opti9xx_mc_size[hardware]; } #else - chip->mc_base_size = opti9xx_mc_size[hardware]; + chip->mc_base_size = opti9xx_mc_size[hardware]; #endif
switch (hardware) { @@ -485,7 +485,7 @@ static int snd_opti9xx_configure(struct snd_opti9xx *chip, #endif /* CS4231 || OPTi93X */
#ifndef OPTi93X - outb(irq_bits << 3 | dma_bits, chip->wss_base); + outb(irq_bits << 3 | dma_bits, chip->wss_base); #else /* OPTi93X */ snd_opti9xx_write(chip, OPTi9XX_MC_REG(3), (irq_bits << 3 | dma_bits)); #endif /* OPTi93X */
On Fri, 16 Apr 2021 11:59:58 +0200, Yang Li wrote:
Kernel test robot throws below warning ->
smatch warnings: sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn: inconsistent indenting sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn: inconsistent indenting
Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com
sound/isa/opti9xx/opti92x-ad1848.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c index 08e61d9..234f023 100644 --- a/sound/isa/opti9xx/opti92x-ad1848.c +++ b/sound/isa/opti9xx/opti92x-ad1848.c @@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip, chip->mc_base_size = opti9xx_mc_size[hardware]; } #else
chip->mc_base_size = opti9xx_mc_size[hardware];
- chip->mc_base_size = opti9xx_mc_size[hardware];
#endif
No, it's not correct.
The ifdef is a bit tricky here but the line you changed belongs to the else section.
thanks,
Takashi
participants (2)
-
Takashi Iwai
-
Yang Li